Skip to content

story(license): add basic setup for license user stories#4

Merged
kahboom merged 3 commits intomainfrom
licenses-setup
Apr 25, 2025
Merged

story(license): add basic setup for license user stories#4
kahboom merged 3 commits intomainfrom
licenses-setup

Conversation

@kahboom
Copy link
Collaborator

@kahboom kahboom commented Apr 24, 2025

Hello this adds the setup for License user stories, mainly the landing page with filtering. I left in a toggle feature but I am not sure yet if we will keep this or remove it. There is no app route, sorting, or pagination.

Changes

  • upgrade patternfly to latest version 6.2.0
  • add license story, page, and "dataset"
  • add some filters and search

Screenshots

Main page:

Screenshot 2025-04-24 at 9 10 21 PM

^ Note there is no "column" for showing the vulnerabilities, packages, or labels yet (like here) and can be done in a future PR, but the filters do work for it.

Search:

Screenshot 2025-04-24 at 9 11 17 PM

Filters:

Screenshot 2025-04-24 at 9 10 47 PM

Screenshot 2025-04-24 at 9 11 36 PM

@kahboom kahboom requested a review from carlosthe19916 April 24, 2025 20:27
@carlosthe19916
Copy link
Member

@kahboom Thanks for putting all these things together. Looks great. In principle I will approve it because it would be good to show it to our PM and then iterate.

I have only one question about the second column of the DataList. Seems like we are rendering "Products". Is the idea to render all products that have the license in the row? E.g. There is a row with the license "Apache License 2.0" and on the right side, second column, there is Red Hat Openshift Container Platform; if there are more products that use the same license I guess we will render them in the same row?

@kahboom
Copy link
Collaborator Author

kahboom commented Apr 25, 2025

@carlosthe19916 thanks for the review. I have the same question, so for now I just assumed a data structure from the mockups, and tried to replicate it exactly like here, where it says that Products are the primary key, and it looked like each Product should have several versions that are shown. So I guessed the grouping is by product.

But let's not merge it yet because I think we should get clarification on that, and also the DataList setup did not end up working well with that data structure anyway.

@kahboom kahboom merged commit 2955b2e into main Apr 25, 2025
2 checks passed
@kahboom kahboom deleted the licenses-setup branch April 25, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants