Migrates Barz and Eth Address APIs to Rust #4422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gupnik
changed the title
…core into gupnik/eth-migration
Binary size comparison➡️ aarch64-apple-ios: - 14.02 MB
+ 14.07 MB +49 KB➡️ aarch64-apple-ios-sim: - 14.02 MB
+ 14.07 MB +49 KB➡️ aarch64-linux-android: - 18.49 MB
+ 18.56 MB +73 KB➡️ armv7-linux-androideabi: - 15.47 MB
+ 15.53 MB +55 KB➡️ wasm32-unknown-emscripten: - 13.17 MB
+ 13.23 MB +54 KB |
satoshiotomakan
suggested changes
Jun 17, 2025
satoshiotomakan
suggested changes
Jun 20, 2025
Contributor
satoshiotomakan
left a comment
satoshiotomakan
left a comment
There was a problem hiding this comment.
Last review iteration. No critical findings, just nice-to-have from my point of view
FATBARB84
reviewed
Jul 10, 2025
| @@ -389,8 +389,8 @@ pub fn sign_authorization( | |||
| let signed_authorization = SignedAuthorization { | |||
| authorization, | |||
| y_parity: signature.v(), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates Barz and Eth Address APIs to Rust
How to test
Types of changes
Refactor
Checklist
If you're adding a new blockchain