Skip to content

fix(abi-encoder): Implement recursion depth limit for parameter encoding and decoding #4717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sergei-boiko-trustwallet wants to merge 3 commits into
base: master
Choose a base branch
from
+209 −55
Open

fix(abi-encoder): Implement recursion depth limit for parameter encoding and decoding #4717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f417cd2
fix(abi-encoder): Implement recursion depth limit for parameter encod…
sergei-boiko-trustwallet Apr 1, 2026
37489e6
Update rust/tw_evm/tests/abi_encoder.rs
sergei-boiko-trustwallet Apr 2, 2026
5959a1f
fix(abi-encoder): Correct comments to reflect array nesting in recurs…
sergei-boiko-trustwallet Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions rust/tw_evm/src/evm_entry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//
// Copyright © 2017 Trust Wallet.

use crate::abi::AbiResult;
use crate::abi::{AbiError, AbiErrorKind, AbiResult};
use crate::evm_context::EvmContext;
use crate::modules::abi_encoder::AbiEncoder;
use crate::modules::rlp_encoder::RlpEncoder;
Expand Down Expand Up @@ -47,7 +47,9 @@ pub trait EvmEntry {

/// Returns the function type signature, of the form "baz(int32,uint256)".
#[inline]
fn get_function_signature_from_proto(input: AbiProto::FunctionGetTypeInput<'_>) -> String {
fn get_function_signature_from_proto(
input: AbiProto::FunctionGetTypeInput<'_>,
) -> AbiResult<String> {
AbiEncoder::<Self::Context>::get_function_signature_from_proto(input)
}

Expand Down Expand Up @@ -78,7 +80,7 @@ pub trait EvmEntryExt {
fn decode_abi_params(&self, input: &[u8]) -> ProtoResult<Data>;

/// Returns the function type signature, of the form "baz(int32,uint256)".
fn get_function_signature_from_proto(&self, input: &[u8]) -> ProtoResult<String>;
fn get_function_signature_from_proto(&self, input: &[u8]) -> AbiResult<String>;

/// Returns the function type signature, of the form "baz(int32,uint256)".
fn get_function_signature_from_abi(&self, abi: &str) -> AbiResult<String>;
Expand Down Expand Up @@ -112,9 +114,11 @@ where
serialize(&output)
}

fn get_function_signature_from_proto(&self, input: &[u8]) -> ProtoResult<String> {
let input = deserialize(input)?;
Ok(<Self as EvmEntry>::get_function_signature_from_proto(input))
fn get_function_signature_from_proto(&self, input: &[u8]) -> AbiResult<String> {
let Ok(input) = deserialize(input) else {
return AbiError::err(AbiErrorKind::Error_decoding_data);
};
<Self as EvmEntry>::get_function_signature_from_proto(input)
}

fn get_function_signature_from_abi(&self, abi: &str) -> AbiResult<String> {
Expand Down
Loading
Loading