Add VinuChain (coin type 10000207)#4722
Open
ElemontCapital wants to merge 4 commits intotrustwallet:masterfrom
Open
Add VinuChain (coin type 10000207)#4722ElemontCapital wants to merge 4 commits intotrustwallet:masterfrom
ElemontCapital wants to merge 4 commits intotrustwallet:masterfrom
Conversation
Add VinuChain as an EVM-compatible chain with: - Chain ID: 207 - Coin type: 10000207 (10000000 + chainId convention) - Symbol: VC - Decimals: 18 - Address derivation: identical to Ethereum (secp256k1, keccak256) - Explorer: https://vinuexplorer.org - Website: https://vinuchain.org Files changed: - registry.json: new chain entry - codegen-v2/manifest/TWEthereumChainID.yaml: chain ID 207 - codegen-v2/manifest/TWCoinType.yaml: coin type 10000207 - include/TrustWalletCore/TWCoinType.h: TWCoinTypeVinuChain enum value - tests/chains/VinuChain/TWCoinTypeTests.cpp: coin type test - tests/common/CoinAddressDerivationTests.cpp: EVM address derivation - rust/tw_tests/tests/coin_address_derivation_test.rs: Rust derivation test - swift/Tests/CoinAddressDerivationTests.swift: Swift derivation test - kotlin/.../CoinAddressDerivationTests.kt: Kotlin multiplatform test - android/.../CoinAddressDerivationTests.kt: Android Kotlin test
4 tasks
|
`` |
1 similar comment
|
`` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds VinuChain as an EVM-compatible chain to Trust Wallet Core.
Chain details:
Files changed
registry.json— new chain entry with all metadatacodegen-v2/manifest/TWEthereumChainID.yaml— chain ID 207 (vinuchain)codegen-v2/manifest/TWCoinType.yaml— coin type 10000207 (vinuchain)include/TrustWalletCore/TWCoinType.h—TWCoinTypeVinuChain = 10000207enum valuetests/chains/VinuChain/TWCoinTypeTests.cpp— coin type configuration testtests/common/CoinAddressDerivationTests.cpp— EVM address derivation caserust/tw_tests/tests/coin_address_derivation_test.rs— Rust derivation testswift/Tests/CoinAddressDerivationTests.swift— Swift derivation testkotlin/wallet-core-kotlin/.../CoinAddressDerivationTests.kt— Kotlin multiplatform testandroid/.../CoinAddressDerivationTests.kt— Android Kotlin testTest plan
TWCoinTypeVinuChain = 10000207resolves correctly0x...)registry.json207is returned byTWCoinTypeChainIdtests/chains/VinuChain/TWCoinTypeTests.cpptest suiteCoinAddressDerivationTestsacross all platforms (C++, Rust, Swift, Kotlin, Android)