Skip to content

fix(xrp): Don't set LastLedgerSequence when not provided in SigningInput #4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MJamalian wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(xrp): Don't set LastLedgerSequence when not provided in SigningInput #4732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions rust/chains/tw_ripple/src/modules/protobuf_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,11 @@ impl<'a> ProtobufBuilder<'a> {
tx.common_fields.sequence = Some(self.input.sequence);
}

// Check whether `SigningInput.last_ledger_sequence` is specified, or JSON transaction doesn't contain that field,
// then override the field.
if self.input.last_ledger_sequence != 0 || tx.common_fields.last_ledger_sequence.is_none() {
// Check whether `SigningInput.last_ledger_sequence` is specified,
// then override the field. A value of 0 means "not provided" (proto default),
// so we must not set it — `LastLedgerSequence = 0` would cause
// immediate transaction expiry on the XRP Ledger.
if self.input.last_ledger_sequence != 0 {
tx.common_fields.last_ledger_sequence = Some(self.input.last_ledger_sequence);
}

Expand Down Expand Up @@ -332,8 +334,14 @@ impl<'a> ProtobufBuilder<'a> {
builder
.fee(fee)
.flags(self.input.flags.try_into_u32("inputFlags")?)
.sequence(self.input.sequence)
.last_ledger_sequence(self.input.last_ledger_sequence)
.sequence(self.input.sequence);
// Only set `LastLedgerSequence` when explicitly provided (non-zero).
// Proto default 0 means "not provided" — setting it to 0 would cause
// immediate transaction expiry on the XRP Ledger.
if self.input.last_ledger_sequence != 0 {
builder.last_ledger_sequence(self.input.last_ledger_sequence);
}
builder
.account_str(self.input.account.as_ref())?
.signing_pub_key(&signing_public_key);
if self.input.source_tag != 0 {
Expand Down