Skip to content

Conversation

@RobGeada
Copy link
Contributor

@RobGeada RobGeada commented Jul 16, 2025

This makes sure that the existing k8s deployment config can successfully launch the new python server,

Summary by Sourcery

Enhancements:

  • Update the built-in Detector Dockerfile to support launching the new Python server while preserving backward compatibility with legacy detectors

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 16, 2025

Reviewer's Guide

This PR updates the built-in Dockerfile to support the new Python-based detector server while preserving backwards compatibility with legacy detectors by switching the base image, installing Python dependencies, introducing an entrypoint wrapper, and revising the health check.

File-Level Changes

Change Details Files
Switch to a Python base image and install dependencies
  • Change FROM alpine to python:3.9-slim
  • Install pip and system packages for Python
  • Copy requirements.txt and run pip install
detectors/Dockerfile.builtIn
Introduce entrypoint logic to preserve legacy detector startup
  • Add entrypoint.sh to select between legacy binary and Python server
  • Set ENTRYPOINT to the new wrapper script
  • Retain CMD fallback to the legacy detector binary
detectors/Dockerfile.builtIn
Update container health check to target the Python server
  • Modify HEALTHCHECK to curl the /healthz endpoint
  • Adjust interval and timeout settings to existing values
detectors/Dockerfile.builtIn

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RobGeada - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@RobGeada RobGeada merged commit 3cd08be into main Jul 16, 2025
2 checks passed
@github-actions
Copy link

github-actions bot commented Jul 16, 2025

PR image build completed successfully!

📦 PR image: quay.io/trustyai/guardrails-detector-huggingface-runtime-ci:b31557d4061a463d29738f8da409d024da7eaca1
📦 PR image: quay.io/trustyai/builtin-detector-ci:b31557d4061a463d29738f8da409d024da7eaca1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants