Skip to content

Conversation

@varad-ahirwadkar
Copy link
Contributor

@varad-ahirwadkar varad-ahirwadkar commented Sep 1, 2025

Adding support for ppc64le compatible guadrails Hugging Face runtime in multi-arch Dockerfile.hf.

build logs:

Summary by Sourcery

Add ppc64le architecture support to the guardrails Hugging Face multi-arch Dockerfile

New Features:

  • Enable building the guardrails Hugging Face runtime image on ppc64le
  • Integrate ppc64le-specific build steps into the multi-arch Dockerfile.hf

Tests:

  • Include build logs for x86_64 and ppc64le to validate the multi-arch build

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 1, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enhances the multi-arch Dockerfile.hf to support ppc64le by parameterizing the base image, adjusting dependency installation for cross-architecture compatibility, and integrating QEMU emulation for seamless builds on both x86_64 and ppc64le.

File-Level Changes

Change Details Files
Parameterize and override the base image for multi-arch builds
  • Introduce ARG for BASE_IMAGE with default value
  • Update FROM to use the BASE_IMAGE argument and --platform flag
  • Ensure platform can be set at build time
detectors/Dockerfile.hf
Adapt package installation for ppc64le compatibility
  • Refactor apt-get commands to avoid x86-only binaries
  • Remove hardcoded architecture flags from library installs
  • Add fallback logic for ppc64le library paths
detectors/Dockerfile.hf
Integrate QEMU for cross-architecture emulation
  • Add QEMU registration step in the Dockerfile
  • Enable binfmt_misc for ppc64le during the build
  • Document multi-arch build steps within the Dockerfile comments
detectors/Dockerfile.hf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@varad-ahirwadkar
Copy link
Contributor Author

Hi @m-misiura, could you please review this PR ? Thanks!
/cc @m-misiura

@m-misiura
Copy link
Collaborator

lgtm

@m-misiura m-misiura merged commit 9cd2d2c into trustyai-explainability:main Sep 2, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants