Skip to content

Conversation

@ruivieira
Copy link
Member

@ruivieira ruivieira commented Jun 9, 2025

Summary by Sourcery

Add a new ConfigMap containing LMEval task metadata and update kustomization to include the configmaps directory for deployment.

New Features:

  • Add ConfigMap listing LMEval tasks and descriptions

Enhancements:

  • Add config/configmaps kustomization and include it in base resources

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 9, 2025

Reviewer's Guide

This PR introduces a new ConfigMap containing LMEval task definitions and hooks it into the base kustomization flow.

File-Level Changes

Change Details Files
Extended the base kustomization to include the new ConfigMap directory
  • Added '../configmaps' to resources list
  • Retained existing commonLabels unchanged
config/base/kustomization.yaml
Created a kustomization for the LMEval tasks ConfigMap
  • Initialized config/configmaps kustomization
  • Referenced 'trustyai-lmeval-tasks.yaml' as a resource
config/configmaps/kustomization.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2025

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e fb79014 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RobGeada

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:fb7901486f63e1d2ac1d7fa37c048629dc8f4c7d

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver-ci:fb7901486f63e1d2ac1d7fa37c048629dc8f4c7d

📦 LMES job image: quay.io/trustyai/ta-lmes-job-ci:fb7901486f63e1d2ac1d7fa37c048629dc8f4c7d

📦 Guardrails orchestrator image: quay.io/trustyai/ta-guardrails-orchestrator-ci:fb7901486f63e1d2ac1d7fa37c048629dc8f4c7d

🗂️ CI manifests

      devFlags:
        manifests:
          - contextDir: config
            sourcePath: ''
            uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-fb7901486f63e1d2ac1d7fa37c048629dc8f4c7d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request lgtm

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants