-
Couldn't load subscription status.
- Fork 45
refactor: Remove v1alpha1 API version #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: Remove v1alpha1 API version #563
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reviewer's GuideThis PR refactors the operator to drop the v1alpha1 API version and fully adopt the v1 storage version by removing all alpha code and schema, updating imports and type references, and adjusting examples and CRDs accordingly. Entity relationship diagram for TrustyAIService CRD after v1alpha1 removalerDiagram
TrustyAIService {
string apiVersion
string kind
object metadata
TrustyAIServiceSpec spec
TrustyAIServiceStatus status
}
TrustyAIServiceSpec {
Data data
Metrics metrics
int replicas
Storage storage
}
Data {
string filename
string format
}
Metrics {
int batchSize
string schedule
}
Storage {
string databaseConfigurations
string folder
string format
string size
}
TrustyAIServiceStatus {
Condition[] conditions
string phase
string ready
int replicas
}
Condition {
string lastTransitionTime
string message
string reason
string status
string type
}
TrustyAIServiceSpec ||--o| Data : contains
TrustyAIServiceSpec ||--o| Metrics : contains
TrustyAIServiceSpec ||--o| Storage : contains
TrustyAIServiceStatus ||--|{ Condition : has
TrustyAIService ||--o| TrustyAIServiceSpec : has
TrustyAIService ||--o| TrustyAIServiceStatus : has
Class diagram for TrustyAIService type reference update to v1classDiagram
class TrustyAIServiceReconciler {
+updateStatus(ctx, original: TrustyAIService, update)
+reconcileStatuses(ctx, instance: TrustyAIService)
+createDeploymentObject(ctx, instance: TrustyAIService, serviceImage, caBundle)
+createDeployment(ctx, cr: TrustyAIService, imageName, caBundle)
+updateDeployment(ctx, cr: TrustyAIService, imageName, caBundle)
+ensureDeployment(ctx, instance: TrustyAIService, caBundle, migration)
+checkDeploymentReady(ctx, instance: TrustyAIService)
+createRouteObject(ctx, instance: TrustyAIService)
+reconcileRouteAuth(instance: TrustyAIService, ctx, newRoute)
+ReconcileRoute(instance: TrustyAIService, ctx)
+checkRouteReady(ctx, cr: TrustyAIService)
+eventModelMeshConfigured(instance: TrustyAIService)
+eventKServeConfigured(instance: TrustyAIService)
+eventPVCCreated(instance: TrustyAIService)
+eventLocalServiceMonitorCreated(instance: TrustyAIService)
+patchEnvVarsForDeployments(ctx, instance: TrustyAIService, ...)
+patchEnvVarsByLabelForDeployments(ctx, instance: TrustyAIService, ...)
+handleInferenceServices(ctx, instance: TrustyAIService, ...)
+patchKServe(ctx, instance: TrustyAIService, ...)
+generatePVCName(instance: TrustyAIService)
+ensurePVC(ctx, instance: TrustyAIService)
+createPVC(ctx, instance: TrustyAIService)
+checkPVCReady(ctx, instance: TrustyAIService)
+generateServiceAccountName(instance: TrustyAIService)
+createServiceAccount(ctx, instance: TrustyAIService)
+createClusterRoleBinding(ctx, instance: TrustyAIService, serviceAccountName)
+GetCustomCertificatesBundle(ctx, instance: TrustyAIService)
+checkDatabaseAccessible(ctx, instance: TrustyAIService)
+ensureDestinationRule(ctx, instance: TrustyAIService)
+deleteExternalDependency(crName, instance: TrustyAIService, namespace, ctx)
+ensureLocalServiceMonitor(cr: TrustyAIService, ctx)
+findDatabaseSecret(ctx, instance: TrustyAIService)
+reconcileService(ctx, cr: TrustyAIService)
+ensureVirtualService(ctx, instance: TrustyAIService)
}
class TrustyAIService {
+Spec
+Status
}
TrustyAIServiceReconciler --> TrustyAIService : manages
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary by Sourcery
Remove support for the deprecated v1alpha1 API version and consolidate on the v1 storage version
Enhancements: