Skip to content

fix(rbac): add update verb to mlflow jobs ClusterRole for run creation#648

Merged
ruivieira merged 1 commit intotrustyai-explainability:mainfrom
ruivieira:fix-mlflow-permissions
Feb 16, 2026
Merged

fix(rbac): add update verb to mlflow jobs ClusterRole for run creation#648
ruivieira merged 1 commit intotrustyai-explainability:mainfrom
ruivieira:fix-mlflow-permissions

Conversation

@ruivieira
Copy link
Member

@ruivieira ruivieira commented Feb 16, 2026

Add update verb to mlflow jobs ClusterRole for run creation.

Summary by CodeRabbit

  • Chores
    • Updated access permissions to enable experiment update operations within the MLflow job execution environment.

@ruivieira ruivieira requested a review from tarilabs February 16, 2026 22:45
@ruivieira ruivieira self-assigned this Feb 16, 2026
@ruivieira ruivieira added the kind/enhancement New feature or request label Feb 16, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The evalhub-mlflow-jobs-access ClusterRole was updated to grant the "update" verb for the experiments resource in the MLflow Kubeflow API group, expanding permissions from create, get, and list to include update operations.

Changes

Cohort / File(s) Summary
RBAC Configuration
config/rbac/evalhub/evalhub_mlflow_jobs_role.yaml
Added "update" verb to the experiments resource verbs list in the evalhub-mlflow-jobs-access ClusterRole, enabling update operations on MLflow experiments while maintaining restrictions on delete operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hopped through RBAC rules,
Adding "update" to the toolbox jewels,
Experiments now dance and sway,
With fresh permissions come new ways!

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding the update verb to the mlflow jobs ClusterRole, directly related to the file modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saichandrapandraju

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira merged commit 04484d2 into trustyai-explainability:main Feb 16, 2026
9 of 10 checks passed
@ruivieira ruivieira deleted the fix-mlflow-permissions branch February 16, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request lgtm

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants