Skip to content

Conversation

@jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Sep 27, 2025

... which is emitted in perl-5.43.2 and forward.

... which is emitted in perl-5.43.2 and forward.
@trwyant trwyant merged commit d0d293f into trwyant:master Sep 27, 2025
6 checks passed
@trwyant
Copy link
Owner

trwyant commented Sep 27, 2025

Thank you very much. I have accepted this pull request as written.

I'm curious what triggered the addition of use PPI::Document;. It is, of course, already loaded, but this module appears not to make use of it. I do see that statement in PPIx::Token::Interpolation, but I believe it is not needed there either.

@jkeenan jkeenan deleted the avoid-escape-whitespace-warning-20250927 branch September 28, 2025 00:44
@jkeenan
Copy link
Contributor Author

jkeenan commented Sep 28, 2025

Thank you very much. I have accepted this pull request as written.

I'm curious what triggered the addition of use PPI::Document;. It is, of course, already loaded, but this module appears not to make use of it. I do see that statement in PPIx::Token::Interpolation, but I believe it is not needed there either.

At this point I cannot say exactly. All I can remember was that I was (a) testing a large number of modules against a branch of the Perl core distribution which I'm developing, and I saw that "Possible" warning flowing past me on STDOUT and, as I was developing the p.r., at one point I got something like Cannot find PPI::Document in @INC. So I tossed in the use PPI::Document; statement, the test program compiled and ran, and didn't explore further.

(BTW: With respect to Perl/perl5#23738, I think you can get by by just squashing your two commits into one and force-pushing your branch. Something like:

$ git checkout mybranch
$ git rebase -i HEAD^^
# change the key on the second commit to 's'; save in text editor; edit the commit message; save
$ git show
$ git push --force mybranch

Since git is saying No conflict with base branch, there won't (or shouldn't) be any merge conflicts when we (P5P -- in practice, khw or me) merge it into blead.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants