-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Update summaries for two GET /finetuning endpoints for conciseness #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe summaries for two GET endpoints under the /finetuning tag in the OpenAPI specification were updated to use more concise language. No other aspects of the endpoints, such as descriptions, parameters, or operation IDs, were altered. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/libs/Cohere/openapi.yaml (2)
5905-5905: Polish summary wording for consistency & clarity“Fetch history of statuses for a fine-tuned model.” is a bit awkward (“history of statuses”) and introduces a new verb (“Fetch”) while nearby endpoints largely start with “Retrieve” or “List”. To stay consistent with the rest of the spec and to read more naturally, consider:
- summary: Fetch history of statuses for a fine-tuned model. + summary: List status events for a fine-tuned model.
6018-6018: Use singular noun to match the path & align with other summariesThe endpoint operates on one model (
/finetuning/{id}/…), yet the summary says “models”. Align wording and keep the same imperative verb used elsewhere:- summary: Retrieve training metrics for fine-tuned models. + summary: Retrieve training metrics for a fine-tuned model.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
src/libs/Cohere/Generated/Cohere.FinetuningClient.ListEvents.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.FinetuningClient.ListTrainingStepMetrics.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.IFinetuningClient.ListEvents.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.IFinetuningClient.ListTrainingStepMetrics.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Cohere/openapi.yaml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test / Build, test and publish
Summary by CodeRabbit