-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Add usage_iframe_url and usage_iframe_dark_mode_url to metronome_links schemas #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughTwo new string properties, Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/libs/Ideogram/openapi.yaml (2)
1433-1439: Add URL format hint to new properties
Theusage_iframe_urlandusage_iframe_dark_mode_urlproperties represent URLs. Consider addingformat: urito these schema definitions to improve validation and tooling support:properties: usage_iframe_url: title: usage_iframe_url type: string + format: uri description: The URL to display the customer usage dashboard. usage_iframe_dark_mode_url: title: usage_iframe_dark_mode_url type: string + format: uri description: 'The URL to display the customer usage dashboard, in dark mode.'
1442-1443: Sync schema example with property definitions
TheMetronomeLinksexample now includes the two new usage URLs. Verify that the example ordering reflects the declared property order (invoices, credits, usage) or adjust for consistency. You may also want to include realistic example values (e.g.,https://app.ideogram.ai/usage?iframe=true) to guide users.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/libs/Ideogram/Generated/Ideogram.Models.MetronomeLinks.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Ideogram/openapi.yaml(2 hunks)
🔇 Additional comments (1)
src/libs/Ideogram/openapi.yaml (1)
1407-1408: Include new fields in ManageApiSubscriptionResponse example
The example underManageApiSubscriptionResponse.metronome_linkscorrectly demonstrates the newly addedusage_iframe_urlandusage_iframe_dark_mode_urlproperties. Ensure that any example consumers or documentation generators pick up these additions.
Summary by CodeRabbit