Skip to content

fix(process-ext): Remove lazy static #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
load1n9 merged 1 commit into from
Nov 6, 2025
Merged

fix(process-ext): Remove lazy static #186

load1n9 merged 1 commit into from
Nov 6, 2025

Conversation

@marc2332
Copy link
Member

@marc2332 marc2332 commented Nov 1, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Performance Comparison →

Total Elapsed Time: 48.16ms → 50.79ms (+5.4%)

Profiling Mode: timing - Execution duration of functions.

+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+
| Function                            | Calls                | Avg                              | P50                             | P95                             | P99                            | Total                            | % Total                      |
+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+
| andromeda::main                     | 1 → 1 (+0.0%)        | 47.51ms → 45.20ms (-4.9%)        | 47.51ms → 45.22ms (-4.8%)       | 47.51ms → 45.22ms (-4.8%)       | 47.51ms → 45.22ms (-4.8%)      | 47.51ms → 45.20ms (-4.9%)        | 100.00% → 100.00% (+0.0%)    |
+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+
| andromeda::run_main                 | 1 → 1 (+0.0%)        | 47.49ms → 45.18ms (-4.9%)        | 47.51ms → 45.19ms (-4.9%)       | 47.51ms → 45.19ms (-4.9%)       | 47.51ms → 45.19ms (-4.9%)      | 47.49ms → 45.18ms (-4.9%)        | 99.95% → 99.95% (+0.0%)      |
+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+
| run::run                            | 1 → 1 (+0.0%)        | 47.01ms → 44.68ms (-5.0%)        | 47.02ms → 44.70ms (-4.9%)       | 47.02ms → 44.70ms (-4.9%)       | 47.02ms → 44.70ms (-4.9%)      | 47.01ms → 44.68ms (-5.0%)        | 98.94% → 98.84% (-0.1%)      |
+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+
| run::create_runtime_files           | 1 → 1 (+0.0%)        | 47.01ms → 44.68ms (-5.0%)        | 47.02ms → 44.70ms (-4.9%)       | 47.02ms → 44.70ms (-4.9%)       | 47.02ms → 44.70ms (-4.9%)      | 47.01ms → 44.68ms (-5.0%)        | 98.93% → 98.83% (-0.1%)      |
+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+
| runtime::run                        | 1 → 1 (+0.0%)        | 26.82ms → 24.35ms (-9.2%)        | 26.82ms → 24.36ms (-9.2%)       | 26.82ms → 24.36ms (-9.2%)       | 26.82ms → 24.36ms (-9.2%)      | 26.82ms → 24.35ms (-9.2%)        | 56.44% → 53.87% (-4.6%)      |
+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+
| runtime::new                        | 1 → 1 (+0.0%)        | 18.94ms → 18.97ms (+0.1%)        | 18.96ms → 18.97ms (+0.1%)       | 18.96ms → 18.97ms (+0.1%)       | 18.96ms → 18.97ms (+0.1%)      | 18.94ms → 18.97ms (+0.1%)        | 39.86% → 41.96% (+5.3%)      |
+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+
| extension::load                     | 22 → 22 (+0.0%)      | 829.61µs → 832.04µs (+0.3%)      | 309.25µs → 318.72µs (+3.1%)     | 2.99ms → 2.97ms (-0.8%)         | 5.63ms → 5.69ms (+0.9%)        | 18.25ms → 18.30ms (+0.3%)        | 38.41% → 40.49% (+5.4%)      |
+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+
| console::internal_print             | 180 → 180 (+0.0%)    | 5.18µs → 4.08µs (-21.3%) 🚀      | 5.07µs → 3.74µs (-26.3%) 🚀     | 5.83µs → 6.28µs (+7.8%)         | 11.42µs → 15.63µs (+36.9%) ⚠️  | 932.35µs → 733.93µs (-21.3%) 🚀  | 1.96% → 1.62% (-17.3%)       |
+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+
| recommended::recommended_extensions | 1 → 1 (+0.0%)        | 58.51µs → 46.25µs (-21.0%) 🚀    | 58.53µs → 46.27µs (-20.9%) 🚀   | 58.53µs → 46.27µs (-20.9%) 🚀   | 58.53µs → 46.27µs (-20.9%) 🚀  | 58.51µs → 46.25µs (-21.0%) 🚀    | 0.12% → 0.10% (-16.7%)       |
+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+
| console::get_group_indent           | 180 → 180 (+0.0%)    | 169.00ns → 101.00ns (-40.2%) 🚀  | 160.00ns → 60.00ns (-62.5%) 🚀  | 270.00ns → 240.00ns (-11.1%)    | 410.00ns → 371.00ns (-9.5%)    | 30.47µs → 18.30µs (-39.9%) 🚀    | 0.06% → 0.04% (-33.3%) 🚀    |
+-------------------------------------+----------------------+----------------------------------+---------------------------------+---------------------------------+--------------------------------+----------------------------------+------------------------------+

Generated with hotpath

📊 View Raw JSON Metrics

PR Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 50788395,
  "description": "Execution duration of functions.",
  "caller_name": "andromeda::main",
  "output": {
    "recommended::recommended_extensions": {
      "calls": 1,
      "avg": 46246,
      "p50": 46271,
      "p95": 46271,
      "p99": 46271,
      "total": 46246,
      "percent_total": 10
    },
    "runtime::run": {
      "calls": 1,
      "avg": 24352592,
      "p50": 24363007,
      "p95": 24363007,
      "p99": 24363007,
      "total": 24352592,
      "percent_total": 5387
    },
    "run::create_runtime_files": {
      "calls": 1,
      "avg": 44677828,
      "p50": 44695551,
      "p95": 44695551,
      "p99": 44695551,
      "total": 44677828,
      "percent_total": 9883
    },
    "run::run": {
      "calls": 1,
      "avg": 44682397,
      "p50": 44695551,
      "p95": 44695551,
      "p99": 44695551,
      "total": 44682397,
      "percent_total": 9884
    },
    "console::get_group_indent": {
      "calls": 180,
      "avg": 101,
      "p50": 60,
      "p95": 240,
      "p99": 371,
      "total": 18304,
      "percent_total": 4
    },
    "andromeda::run_main": {
      "calls": 1,
      "avg": 45183558,
      "p50": 45187071,
      "p95": 45187071,
      "p99": 45187071,
      "total": 45183558,
      "percent_total": 9995
    },
    "andromeda::main": {
      "calls": 1,
      "avg": 45202534,
      "p50": 45219839,
      "p95": 45219839,
      "p99": 45219839,
      "total": 45202534,
      "percent_total": 10000
    },
    "extension::load": {
      "calls": 22,
      "avg": 832041,
      "p50": 318719,
      "p95": 2965503,
      "p99": 5685247,
      "total": 18304910,
      "percent_total": 4049
    },
    "runtime::new": {
      "calls": 1,
      "avg": 18968896,
      "p50": 18972671,
      "p95": 18972671,
      "p99": 18972671,
      "total": 18968896,
      "percent_total": 4196
    },
    "console::internal_print": {
      "calls": 180,
      "avg": 4077,
      "p50": 3737,
      "p95": 6283,
      "p99": 15631,
      "total": 733927,
      "percent_total": 162
    }
  }
}

Main Branch Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 48164741,
  "description": "Execution duration of functions.",
  "caller_name": "andromeda::main",
  "output": {
    "console::internal_print": {
      "calls": 180,
      "avg": 5179,
      "p50": 5071,
      "p95": 5831,
      "p99": 11415,
      "total": 932353,
      "percent_total": 196
    },
    "andromeda::main": {
      "calls": 1,
      "avg": 47512695,
      "p50": 47513599,
      "p95": 47513599,
      "p99": 47513599,
      "total": 47512695,
      "percent_total": 10000
    },
    "andromeda::run_main": {
      "calls": 1,
      "avg": 47491885,
      "p50": 47513599,
      "p95": 47513599,
      "p99": 47513599,
      "total": 47491885,
      "percent_total": 9995
    },
    "extension::load": {
      "calls": 22,
      "avg": 829614,
      "p50": 309247,
      "p95": 2990079,
      "p99": 5631999,
      "total": 18251528,
      "percent_total": 3841
    },
    "recommended::recommended_extensions": {
      "calls": 1,
      "avg": 58510,
      "p50": 58527,
      "p95": 58527,
      "p99": 58527,
      "total": 58510,
      "percent_total": 12
    },
    "console::get_group_indent": {
      "calls": 180,
      "avg": 169,
      "p50": 160,
      "p95": 270,
      "p99": 410,
      "total": 30468,
      "percent_total": 6
    },
    "run::run": {
      "calls": 1,
      "avg": 47012031,
      "p50": 47022079,
      "p95": 47022079,
      "p99": 47022079,
      "total": 47012031,
      "percent_total": 9894
    },
    "runtime::new": {
      "calls": 1,
      "avg": 18942431,
      "p50": 18956287,
      "p95": 18956287,
      "p99": 18956287,
      "total": 18942431,
      "percent_total": 3986
    },
    "run::create_runtime_files": {
      "calls": 1,
      "avg": 47007282,
      "p50": 47022079,
      "p95": 47022079,
      "p99": 47022079,
      "total": 47007282,
      "percent_total": 9893
    },
    "runtime::run": {
      "calls": 1,
      "avg": 26817461,
      "p50": 26820607,
      "p95": 26820607,
      "p99": 26820607,
      "total": 26817461,
      "percent_total": 5644
    }
  }
}

load1n9
load1n9 approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@load1n9 load1n9 merged commit df5adf3 into main Nov 6, 2025
8 checks passed
@load1n9 load1n9 deleted the fix/remove-lazy-static-process-ext branch November 6, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@load1n9 load1n9 load1n9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc2332 @load1n9