Skip to content

Conversation

@yossydev
Copy link
Member

@yossydev yossydev commented Nov 11, 2025

@yossydev yossydev self-assigned this Nov 11, 2025
@yossydev yossydev requested a review from load1n9 November 11, 2025 15:54
@yossydev yossydev marked this pull request as ready for review November 11, 2025 15:56
@github-actions
Copy link

Performance Comparison

Total Elapsed Time: 50.24ms → 47.13ms (-6.2%)

Profiling Mode: timing - Execution duration of functions.

+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+
| Function                            | Calls                | Avg                              | P50                              | P95                             | P99                             | Total                           | % Total                      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+
| andromeda::main                     | 1 → 1 (+0.0%)        | 49.54ms → 46.45ms (-6.2%)        | 49.55ms → 46.47ms (-6.2%)        | 49.55ms → 46.47ms (-6.2%)       | 49.55ms → 46.47ms (-6.2%)       | 49.54ms → 46.45ms (-6.2%)       | 100.00% → 100.00% (+0.0%)    |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+
| andromeda::run_main                 | 1 → 1 (+0.0%)        | 49.52ms → 46.43ms (-6.2%)        | 49.55ms → 46.47ms (-6.2%)        | 49.55ms → 46.47ms (-6.2%)       | 49.55ms → 46.47ms (-6.2%)       | 49.52ms → 46.43ms (-6.2%)       | 99.96% → 99.95% (-0.0%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+
| run::run                            | 1 → 1 (+0.0%)        | 49.02ms → 45.96ms (-6.2%)        | 49.02ms → 45.97ms (-6.2%)        | 49.02ms → 45.97ms (-6.2%)       | 49.02ms → 45.97ms (-6.2%)       | 49.02ms → 45.96ms (-6.2%)       | 98.95% → 98.93% (-0.0%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+
| run::create_runtime_files           | 1 → 1 (+0.0%)        | 49.02ms → 45.96ms (-6.2%)        | 49.02ms → 45.97ms (-6.2%)        | 49.02ms → 45.97ms (-6.2%)       | 49.02ms → 45.97ms (-6.2%)       | 49.02ms → 45.96ms (-6.2%)       | 98.94% → 98.92% (-0.0%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+
| runtime::run                        | 1 → 1 (+0.0%)        | 27.41ms → 25.61ms (-6.6%)        | 27.43ms → 25.62ms (-6.6%)        | 27.43ms → 25.62ms (-6.6%)       | 27.43ms → 25.62ms (-6.6%)       | 27.41ms → 25.61ms (-6.6%)       | 55.33% → 55.13% (-0.4%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+
| runtime::new                        | 1 → 1 (+0.0%)        | 20.24ms → 19.00ms (-6.1%)        | 20.25ms → 19.01ms (-6.1%)        | 20.25ms → 19.01ms (-6.1%)       | 20.25ms → 19.01ms (-6.1%)       | 20.24ms → 19.00ms (-6.1%)       | 40.85% → 40.91% (+0.1%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+
| extension::load                     | 22 → 22 (+0.0%)      | 880.32µs → 832.29µs (-5.5%)      | 309.76µs → 293.89µs (-5.1%)      | 3.05ms → 3.00ms (-1.7%)         | 5.79ms → 5.73ms (-1.0%)         | 19.37ms → 18.31ms (-5.5%)       | 39.09% → 39.41% (+0.8%)      |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+
| console::internal_print             | 180 → 180 (+0.0%)    | 5.14µs → 4.62µs (-10.1%)         | 4.97µs → 4.60µs (-7.5%)          | 7.02µs → 5.62µs (-19.8%)        | 8.43µs → 13.06µs (+54.8%) ⚠️    | 924.55µs → 830.89µs (-10.1%)    | 1.86% → 1.78% (-4.3%)        |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+
| recommended::recommended_extensions | 1 → 1 (+0.0%)        | 64.64µs → 51.16µs (-20.9%) 🚀    | 64.64µs → 51.17µs (-20.8%) 🚀    | 64.64µs → 51.17µs (-20.8%) 🚀   | 64.64µs → 51.17µs (-20.8%) 🚀   | 64.64µs → 51.16µs (-20.9%) 🚀   | 0.13% → 0.11% (-15.4%)       |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+
| console::get_group_indent           | 180 → 180 (+0.0%)    | 254.00ns → 167.00ns (-34.3%) 🚀  | 241.00ns → 161.00ns (-33.2%) 🚀  | 370.00ns → 301.00ns (-18.6%)    | 571.00ns → 461.00ns (-19.3%)    | 45.85µs → 30.21µs (-34.1%) 🚀   | 0.09% → 0.06% (-33.3%) 🚀    |
+-------------------------------------+----------------------+----------------------------------+----------------------------------+---------------------------------+---------------------------------+---------------------------------+------------------------------+

Generated with hotpath

📊 View Raw JSON Metrics

PR Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 47126096,
  "description": "Execution duration of functions.",
  "caller_name": "andromeda::main",
  "output": {
    "andromeda::main": {
      "calls": 1,
      "avg": 46454142,
      "p50": 46465023,
      "p95": 46465023,
      "p99": 46465023,
      "total": 46454142,
      "percent_total": 10000
    },
    "console::internal_print": {
      "calls": 180,
      "avg": 4616,
      "p50": 4599,
      "p95": 5623,
      "p99": 13055,
      "total": 830891,
      "percent_total": 178
    },
    "runtime::run": {
      "calls": 1,
      "avg": 25614218,
      "p50": 25624575,
      "p95": 25624575,
      "p99": 25624575,
      "total": 25614218,
      "percent_total": 5513
    },
    "extension::load": {
      "calls": 22,
      "avg": 832287,
      "p50": 293887,
      "p95": 2998271,
      "p99": 5734399,
      "total": 18310329,
      "percent_total": 3941
    },
    "recommended::recommended_extensions": {
      "calls": 1,
      "avg": 51155,
      "p50": 51167,
      "p95": 51167,
      "p99": 51167,
      "total": 51155,
      "percent_total": 11
    },
    "andromeda::run_main": {
      "calls": 1,
      "avg": 46434566,
      "p50": 46465023,
      "p95": 46465023,
      "p99": 46465023,
      "total": 46434566,
      "percent_total": 9995
    },
    "run::run": {
      "calls": 1,
      "avg": 45961224,
      "p50": 45973503,
      "p95": 45973503,
      "p99": 45973503,
      "total": 45961224,
      "percent_total": 9893
    },
    "runtime::new": {
      "calls": 1,
      "avg": 19004931,
      "p50": 19005439,
      "p95": 19005439,
      "p99": 19005439,
      "total": 19004931,
      "percent_total": 4091
    },
    "console::get_group_indent": {
      "calls": 180,
      "avg": 167,
      "p50": 161,
      "p95": 301,
      "p99": 461,
      "total": 30208,
      "percent_total": 6
    },
    "run::create_runtime_files": {
      "calls": 1,
      "avg": 45956917,
      "p50": 45973503,
      "p95": 45973503,
      "p99": 45973503,
      "total": 45956917,
      "percent_total": 9892
    }
  }
}

Main Branch Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 50243728,
  "description": "Execution duration of functions.",
  "caller_name": "andromeda::main",
  "output": {
    "console::get_group_indent": {
      "calls": 180,
      "avg": 254,
      "p50": 241,
      "p95": 370,
      "p99": 571,
      "total": 45852,
      "percent_total": 9
    },
    "andromeda::run_main": {
      "calls": 1,
      "avg": 49523465,
      "p50": 49545215,
      "p95": 49545215,
      "p99": 49545215,
      "total": 49523465,
      "percent_total": 9996
    },
    "andromeda::main": {
      "calls": 1,
      "avg": 49540387,
      "p50": 49545215,
      "p95": 49545215,
      "p99": 49545215,
      "total": 49540387,
      "percent_total": 10000
    },
    "run::create_runtime_files": {
      "calls": 1,
      "avg": 49016270,
      "p50": 49020927,
      "p95": 49020927,
      "p99": 49020927,
      "total": 49016270,
      "percent_total": 9894
    },
    "runtime::new": {
      "calls": 1,
      "avg": 20238455,
      "p50": 20250623,
      "p95": 20250623,
      "p99": 20250623,
      "total": 20238455,
      "percent_total": 4085
    },
    "console::internal_print": {
      "calls": 180,
      "avg": 5136,
      "p50": 4971,
      "p95": 7015,
      "p99": 8431,
      "total": 924546,
      "percent_total": 186
    },
    "runtime::run": {
      "calls": 1,
      "avg": 27411865,
      "p50": 27426815,
      "p95": 27426815,
      "p99": 27426815,
      "total": 27411865,
      "percent_total": 5533
    },
    "recommended::recommended_extensions": {
      "calls": 1,
      "avg": 64639,
      "p50": 64639,
      "p95": 64639,
      "p99": 64639,
      "total": 64639,
      "percent_total": 13
    },
    "run::run": {
      "calls": 1,
      "avg": 49020217,
      "p50": 49020927,
      "p95": 49020927,
      "p99": 49020927,
      "total": 49020217,
      "percent_total": 9895
    },
    "extension::load": {
      "calls": 22,
      "avg": 880318,
      "p50": 309759,
      "p95": 3051519,
      "p99": 5791743,
      "total": 19367000,
      "percent_total": 3909
    }
  }
}

@marc2332 marc2332 merged commit ce2a864 into tryandromeda:main Nov 11, 2025
8 checks passed
Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow that was fast! tysm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants