Skip to content

Conversation

@load1n9
Copy link
Member

@load1n9 load1n9 commented Nov 26, 2025

No description provided.

@load1n9 load1n9 requested review from marc2332 and yossydev November 26, 2025 20:06
@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Performance Comparison

Total Elapsed Time: 43.04ms → 40.85ms (-5.1%)

Profiling Mode: timing - Execution duration of functions.

+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+
| Function                            | Calls                | Avg                              | P50                            | P95                             | P99                              | Total                            | % Total                      |
+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+
| andromeda::main                     | 1 → 1 (+0.0%)        | 42.39ms → 40.20ms (-5.2%)        | 42.40ms → 40.21ms (-5.2%)      | 42.40ms → 40.21ms (-5.2%)       | 42.40ms → 40.21ms (-5.2%)        | 42.39ms → 40.20ms (-5.2%)        | 100.00% → 100.00% (+0.0%)    |
+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+
| andromeda::run_main                 | 1 → 1 (+0.0%)        | 42.37ms → 40.18ms (-5.2%)        | 42.40ms → 40.21ms (-5.2%)      | 42.40ms → 40.21ms (-5.2%)       | 42.40ms → 40.21ms (-5.2%)        | 42.37ms → 40.18ms (-5.2%)        | 99.96% → 99.94% (-0.0%)      |
+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+
| run::run                            | 1 → 1 (+0.0%)        | 42.06ms → 39.85ms (-5.2%)        | 42.07ms → 39.88ms (-5.2%)      | 42.07ms → 39.88ms (-5.2%)       | 42.07ms → 39.88ms (-5.2%)        | 42.06ms → 39.85ms (-5.2%)        | 99.22% → 99.13% (-0.1%)      |
+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+
| run::create_runtime_files           | 1 → 1 (+0.0%)        | 42.05ms → 39.85ms (-5.2%)        | 42.07ms → 39.88ms (-5.2%)      | 42.07ms → 39.88ms (-5.2%)       | 42.07ms → 39.88ms (-5.2%)        | 42.05ms → 39.85ms (-5.2%)        | 99.21% → 99.12% (-0.1%)      |
+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+
| runtime::run                        | 1 → 1 (+0.0%)        | 23.19ms → 22.11ms (-4.7%)        | 23.20ms → 22.12ms (-4.7%)      | 23.20ms → 22.12ms (-4.7%)       | 23.20ms → 22.12ms (-4.7%)        | 23.19ms → 22.11ms (-4.7%)        | 54.70% → 54.99% (+0.5%)      |
+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+
| runtime::new                        | 1 → 1 (+0.0%)        | 17.43ms → 16.34ms (-6.3%)        | 17.43ms → 16.34ms (-6.3%)      | 17.43ms → 16.34ms (-6.3%)       | 17.43ms → 16.34ms (-6.3%)        | 17.43ms → 16.34ms (-6.3%)        | 41.12% → 40.63% (-1.2%)      |
+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+
| extension::load                     | 22 → 22 (+0.0%)      | 747.03µs → 713.32µs (-4.5%)      | 254.08µs → 238.98µs (-5.9%)    | 2.53ms → 2.53ms (-0.2%)         | 4.76ms → 4.80ms (+0.9%)          | 16.43ms → 15.69ms (-4.5%)        | 38.77% → 39.03% (+0.7%)      |
+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+
| console::internal_print             | 180 → 180 (+0.0%)    | 4.06µs → 2.66µs (-34.6%) 🚀      | 3.29µs → 2.47µs (-24.8%) 🚀    | 5.10µs → 3.27µs (-36.0%) 🚀     | 16.74µs → 10.01µs (-40.2%) 🚀    | 731.02µs → 478.31µs (-34.6%) 🚀  | 1.72% → 1.18% (-31.4%) 🚀    |
+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+
| recommended::recommended_extensions | 1 → 1 (+0.0%)        | 72.01µs → 53.28µs (-26.0%) 🚀    | 72.06µs → 53.28µs (-26.1%) 🚀  | 72.06µs → 53.28µs (-26.1%) 🚀   | 72.06µs → 53.28µs (-26.1%) 🚀    | 72.01µs → 53.28µs (-26.0%) 🚀    | 0.16% → 0.13% (-18.8%)       |
+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+
| console::get_group_indent           | 180 → 180 (+0.0%)    | 107.00ns → 135.00ns (+26.2%) ⚠️  | 98.00ns → 75.00ns (-23.5%) 🚀  | 178.00ns → 153.00ns (-14.0%)    | 318.00ns → 535.00ns (+68.2%) ⚠️  | 19.40µs → 24.38µs (+25.6%) ⚠️    | 0.04% → 0.06% (+50.0%) ⚠️    |
+-------------------------------------+----------------------+----------------------------------+--------------------------------+---------------------------------+----------------------------------+----------------------------------+------------------------------+

Generated with hotpath-rs

📊 View Raw JSON Metrics

PR Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 40848409,
  "description": "Execution duration of functions.",
  "caller_name": "andromeda::main",
  "output": {
    "extension::load": {
      "calls": 22,
      "avg": 713323,
      "p50": 238975,
      "p95": 2527231,
      "p99": 4804607,
      "total": 15693118,
      "percent_total": 3903
    },
    "run::create_runtime_files": {
      "calls": 1,
      "avg": 39848102,
      "p50": 39878655,
      "p95": 39878655,
      "p99": 39878655,
      "total": 39848102,
      "percent_total": 9912
    },
    "recommended::recommended_extensions": {
      "calls": 1,
      "avg": 53277,
      "p50": 53279,
      "p95": 53279,
      "p99": 53279,
      "total": 53277,
      "percent_total": 13
    },
    "runtime::run": {
      "calls": 1,
      "avg": 22109995,
      "p50": 22118399,
      "p95": 22118399,
      "p99": 22118399,
      "total": 22109995,
      "percent_total": 5499
    },
    "console::get_group_indent": {
      "calls": 180,
      "avg": 135,
      "p50": 75,
      "p95": 153,
      "p99": 535,
      "total": 24379,
      "percent_total": 6
    },
    "runtime::new": {
      "calls": 1,
      "avg": 16335907,
      "p50": 16343039,
      "p95": 16343039,
      "p99": 16343039,
      "total": 16335907,
      "percent_total": 4063
    },
    "andromeda::run_main": {
      "calls": 1,
      "avg": 40181192,
      "p50": 40206335,
      "p95": 40206335,
      "p99": 40206335,
      "total": 40181192,
      "percent_total": 9994
    },
    "console::internal_print": {
      "calls": 180,
      "avg": 2657,
      "p50": 2469,
      "p95": 3267,
      "p99": 10007,
      "total": 478311,
      "percent_total": 118
    },
    "andromeda::main": {
      "calls": 1,
      "avg": 40201644,
      "p50": 40206335,
      "p95": 40206335,
      "p99": 40206335,
      "total": 40201644,
      "percent_total": 10000
    },
    "run::run": {
      "calls": 1,
      "avg": 39853051,
      "p50": 39878655,
      "p95": 39878655,
      "p99": 39878655,
      "total": 39853051,
      "percent_total": 9913
    }
  }
}

Main Branch Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 43036517,
  "description": "Execution duration of functions.",
  "caller_name": "andromeda::main",
  "output": {
    "andromeda::main": {
      "calls": 1,
      "avg": 42386441,
      "p50": 42401791,
      "p95": 42401791,
      "p99": 42401791,
      "total": 42386441,
      "percent_total": 10000
    },
    "runtime::run": {
      "calls": 1,
      "avg": 23189559,
      "p50": 23199743,
      "p95": 23199743,
      "p99": 23199743,
      "total": 23189559,
      "percent_total": 5470
    },
    "run::create_runtime_files": {
      "calls": 1,
      "avg": 42054641,
      "p50": 42074111,
      "p95": 42074111,
      "p99": 42074111,
      "total": 42054641,
      "percent_total": 9921
    },
    "extension::load": {
      "calls": 22,
      "avg": 747026,
      "p50": 254079,
      "p95": 2531327,
      "p99": 4759551,
      "total": 16434572,
      "percent_total": 3877
    },
    "andromeda::run_main": {
      "calls": 1,
      "avg": 42373094,
      "p50": 42401791,
      "p95": 42401791,
      "p99": 42401791,
      "total": 42373094,
      "percent_total": 9996
    },
    "runtime::new": {
      "calls": 1,
      "avg": 17429900,
      "p50": 17432575,
      "p95": 17432575,
      "p99": 17432575,
      "total": 17429900,
      "percent_total": 4112
    },
    "recommended::recommended_extensions": {
      "calls": 1,
      "avg": 72012,
      "p50": 72063,
      "p95": 72063,
      "p99": 72063,
      "total": 72012,
      "percent_total": 16
    },
    "console::get_group_indent": {
      "calls": 180,
      "avg": 107,
      "p50": 98,
      "p95": 178,
      "p99": 318,
      "total": 19404,
      "percent_total": 4
    },
    "console::internal_print": {
      "calls": 180,
      "avg": 4061,
      "p50": 3285,
      "p95": 5103,
      "p99": 16735,
      "total": 731024,
      "percent_total": 172
    },
    "run::run": {
      "calls": 1,
      "avg": 42058713,
      "p50": 42074111,
      "p95": 42074111,
      "p99": 42074111,
      "total": 42058713,
      "percent_total": 9922
    }
  }
}

Copy link
Member

@yossydev yossydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎖️

@load1n9 load1n9 merged commit 0cd2af8 into main Nov 27, 2025
1 check passed
@load1n9 load1n9 deleted the satellite-install branch November 27, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants