Skip to content

feat: Headers constructor and get method#36

Merged
load1n9 merged 5 commits intotryandromeda:mainfrom
yossydev:feat/fetch-headers
Mar 8, 2025
Merged

feat: Headers constructor and get method#36
load1n9 merged 5 commits intotryandromeda:mainfrom
yossydev:feat/fetch-headers

Conversation

@yossydev
Copy link
Member

@yossydev yossydev commented Mar 1, 2025

  • There are a lot of small TODOs, but I have implemented the constructor and get method.
  • Differences from deno fmt.

@yossydev yossydev changed the title WIP feat: headers WIP feat: Headers constructor Mar 1, 2025
@yossydev yossydev force-pushed the feat/fetch-headers branch from 5b687f9 to 346cf7c Compare March 8, 2025 07:34
@yossydev yossydev changed the title WIP feat: Headers constructor feat: Headers constructor Mar 8, 2025
@yossydev yossydev marked this pull request as ready for review March 8, 2025 13:46
@yossydev yossydev changed the title feat: Headers constructor feat: Headers constructor and get method Mar 8, 2025
Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow perfect, just make sure to resolve the merge conflicts!

@yossydev yossydev force-pushed the feat/fetch-headers branch from dcd4016 to 515a915 Compare March 8, 2025 21:35
@yossydev
Copy link
Member Author

yossydev commented Mar 8, 2025

@load1n9

Wow perfect, just make sure to resolve the merge conflicts!

Thank you! Conflicts fixed!

@yossydev
Copy link
Member Author

yossydev commented Mar 8, 2025

Oops, looks like my workflow misses the mark. I'll fix it later.

@yossydev yossydev requested a review from load1n9 March 8, 2025 21:38
Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@load1n9 load1n9 merged commit 28caf45 into tryandromeda:main Mar 8, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants