Skip to content

[comp] Production Deploy#2367

Merged
Marfuen merged 3 commits intoreleasefrom
main
Mar 24, 2026
Merged

[comp] Production Deploy#2367
Marfuen merged 3 commits intoreleasefrom
main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.

github-actions bot and others added 3 commits March 24, 2026 22:45
…le score

The overview scores endpoint always required all 5 CompAI training videos
(sat-1 through sat-5) to be completed, ignoring the org's
securityTrainingStepEnabled setting. This caused orgs that disabled CompAI
training videos to show incorrect people completion counts (e.g., 2/9
instead of 9/9).

Now fetches the org setting and skips training video checks when disabled,
matching the behavior of the People page and portal.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…setting

[dev] [tofikwest] fix/overview-people-training-setting
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-framework-editor Ready Ready Preview, Comment Mar 25, 2026 6:56pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app (staging) Skipped Skipped Mar 25, 2026 6:56pm
portal (staging) Skipped Skipped Mar 25, 2026 6:56pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Mar 24, 2026

PR Summary

Medium Risk
Moderate risk because it changes how getOverviewScores computes the people completion metric and adds a new org-level flag dependency, which can affect customer-visible scores if the setting is missing/misconfigured.

Overview
getOverviewScores now fetches the organization’s securityTrainingStepEnabled flag and uses it to conditionally include security training video completions in the people score.

When the flag is disabled, the helper skips querying employeeTrainingVideoCompletion and treats training as automatically complete, so the “completed members” count is based only on required policy signatures.

Written by Cursor Bugbot for commit cbd4ece. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@Marfuen Marfuen merged commit 6d1aa3f into release Mar 24, 2026
14 checks passed
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants