Skip to content

[comp] Production Deploy#2376

Merged
Marfuen merged 2 commits intoreleasefrom
main
Mar 25, 2026
Merged

[comp] Production Deploy#2376
Marfuen merged 2 commits intoreleasefrom
main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.

github-actions bot and others added 2 commits March 25, 2026 19:16
* fix(vendors): skip assignee validation when assignee hasn't changed

The form sends the existing assigneeId on every PATCH even when
the user only changed a different field (e.g. website). If the
vendor's current assignee is a platform admin, every update fails
with "Cannot assign a platform admin as assignee" — even though
no one is trying to change the assignee.

Only run validateAssigneeNotPlatformAdmin when assigneeId is
actually being changed to a different value.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(vendors): don't assign platform admins as vendor assignees during onboarding

The vendor mitigation task assigned vendors to whoever triggered
onboarding (authorId). When a platform admin onboards a customer,
all vendors get assigned to the admin. Since platform admins are
filtered from the UI assignee list, vendors appear "Unassigned"
but the backend still has the admin's member ID — which then
blocks all PATCH updates with "Cannot assign a platform admin".

Two fixes:
- Service: only validate assignee when it's actually changing
- Onboarding: skip assignee if author is a platform admin

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app (staging) Ready Ready Preview, Comment Mar 25, 2026 8:38pm
comp-framework-editor Ready Ready Preview, Comment Mar 25, 2026 8:38pm
portal (staging) Ready Ready Preview, Comment Mar 25, 2026 8:38pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Mar 25, 2026

PR Summary

Medium Risk
Adjusts vendor assignee handling in both API updates and onboarding automation, which can affect ownership/visibility workflows if role detection or comparison logic is wrong.

Overview
Prevents unnecessary assignee validation when updating a vendor by only checking the assignee’s role if assigneeId is actually changing.

Updates onboarding’s generate-vendor-mitigation task to avoid assigning vendors to platform admins (sets assigneeId to null for admin authors) to prevent hidden assignees from blocking later UI updates.

Written by Cursor Bugbot for commit 9e508c2. This will update automatically on new commits. Configure here.

@Marfuen Marfuen merged commit ac8b676 into release Mar 25, 2026
11 of 12 checks passed
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.11.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants