Skip to content

Fix CI/CD build script fails#125

Merged
sr2echa merged 1 commit intotrykimu:canaryfrom
sr2echa:auth
Aug 27, 2025
Merged

Fix CI/CD build script fails#125
sr2echa merged 1 commit intotrykimu:canaryfrom
sr2echa:auth

Conversation

@sr2echa
Copy link
Member

@sr2echa sr2echa commented Aug 27, 2025

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @sr2echa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses CI/CD build failures by updating the pyproject.toml configuration for the ruff linter. The changes ensure that ruff's linting rules are correctly applied, resolving issues that were previously causing the build to fail.

Highlights

  • Ruff Configuration Update: Refactored the ruff linter configuration in backend/pyproject.toml by moving the select and ignore rule definitions under the new [tool.ruff.lint] section. This aligns the configuration with the latest ruff syntax, resolving previous build failures.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sr2echa sr2echa merged commit e0d67e8 into trykimu:canary Aug 27, 2025
0 of 2 checks passed
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ruff configuration in pyproject.toml to be compatible with newer versions, which fixes the CI/CD build. The change correctly moves the linting rules under the [tool.ruff.lint] section. I've added a couple of suggestions to further improve code quality by refining the selected and ignored linting rules.

line-length = 88

[tool.ruff.lint]
select = ["E", "F", "I", "N", "W", "B", "C4", "UP", "ARG", "SIM", "TCH", "TID", "Q"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a good set of selected rules. To make your linting even more comprehensive, consider adding a few more rule sets:

  • D for pydocstyle to enforce consistent docstrings.
  • S for flake8-bandit to check for common security vulnerabilities.
  • A for flake8-builtins to prevent accidentally shadowing Python's built-in functions.

Enabling these can help improve documentation, security, and prevent subtle bugs.

Suggested change
select = ["E", "F", "I", "N", "W", "B", "C4", "UP", "ARG", "SIM", "TCH", "TID", "Q"]
select = ["E", "F", "I", "N", "W", "B", "C4", "UP", "ARG", "SIM", "TCH", "TID", "Q", "D", "S", "A"]


[tool.ruff.lint]
select = ["E", "F", "I", "N", "W", "B", "C4", "UP", "ARG", "SIM", "TCH", "TID", "Q"]
ignore = ["E501", "B008", "F401", "F841", "W293", "ARG001", "N815"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly updates the ruff configuration format, I've noticed that some important linting rules are being ignored. Specifically, F401 (unused import) and F841 (unused variable) are disabled.

These rules are very helpful for maintaining code quality and catching potential bugs or dead code. For example, in backend/main.py, MediaBinItem and TimelineState are imported but not used. Enabling F401 would have caught this.

I recommend removing F401 and F841 from the ignore list to improve code quality. If there are specific cases where an unused variable is intentional, it's better to prefix it with an underscore (e.g., _my_var) or use a # noqa comment on the specific line.

Suggested change
ignore = ["E501", "B008", "F401", "F841", "W293", "ARG001", "N815"]
ignore = ["E501", "B008", "W293", "ARG001", "N815"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant