Skip to content

[fix] Use existing helper function to determine whether a jobs runner… #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjlgao merged 3 commits into from
Jan 13, 2025
Merged

[fix] Use existing helper function to determine whether a jobs runner… #201

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea24df7
[fix] Use existing helper function to determine whether a jobs runner…
jjlgao Jan 9, 2025
b26f895
bump version
jjlgao Jan 9, 2025
2f692ec
a
jjlgao Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/retool/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: retool
description: A Helm chart for Kubernetes
type: application
version: 6.3.0
version: 6.3.1
maintainers:
- name: Retool Engineering
email: engineering+helm@retool.com
Expand Down
2 changes: 1 addition & 1 deletion charts/retool/templates/deployment_backend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ spec:
It may seem counterintuitive to add the JOBS_RUNNER service type only without a jobs runner.
The reason for this is that the backend needs to act as a jobs runner, if the jobs runner is not enabled.
*/}}
{{- if not .Values.jobRunner.enabled }}
{{- if include "retool.jobRunner.enabled" . }}
{{- $serviceType = append $serviceType "JOBS_RUNNER" }}
{{- end }}
- name: SERVICE_TYPE
Expand Down
Loading