Skip to content

[feat] Flexible security contexts#206

Merged
jjlgao merged 8 commits intomainfrom
jason/flexible-sec-context
Jan 23, 2025
Merged

[feat] Flexible security contexts#206
jjlgao merged 8 commits intomainfrom
jason/flexible-sec-context

Conversation

@jjlgao
Copy link
Contributor

@jjlgao jjlgao commented Jan 22, 2025

Allows users to fully define the security contexts of their pods rather than only supporting a limited list. Previous format must be maintained for backwards compatibility, which necessitates the complex set of if statements.

This is meant to address these issues:

Tested locally, confirmed the following:

  • helm template charts/retool --values charts/retool/ci/test-install-values.yaml runs successfully without error
  • When securityContext.enabled=false, no security context block is added
  • When securityContext.values={}, the legacy values are used
  • When there are values in securityContext.values, those values are overridden, ignoring the legacy values

Update: changed PR to match telemetry deployment model of maintaining legacy params while providing the option to add extra custom ones.

@jjlgao jjlgao merged commit 1852808 into main Jan 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants