allow external secrets to potentially clobber other secrets if opted in#208
Merged
JatinNanda merged 1 commit intomainfrom Jan 27, 2025
Merged
Conversation
jjlgao
reviewed
Jan 24, 2025
JatinNanda
force-pushed
the
jatin/allow-eso-to-specify-postgres-password
branch
4 times, most recently
from
4633878 to
6d7ddf2
Compare
charts/retool/templates/_helpers.tpl
Outdated
| {{/* | ||
| Checks whether or not ExternalSecret definitions are enabled and can potentially clobber secrets or explicitly allow additional direct secret refs. | ||
| */}} | ||
| {{- define "checkExternalSecretsClobbering" -}} |
Contributor
There was a problem hiding this comment.
I would name this something a little more directly tied to what it gates, like shouldIncludeConfigSecretsEnvVars or smth
charts/retool/values.yaml
Outdated
| enabled: false | ||
| # If external secrets are currently enabled, it is disallowed to specify regular configuration secrets as a safeguard from clobbering. | ||
| # This flag allows bypassing that check and specifying both an ExternalSecret and a regular secret for different secrets. | ||
| allowOtherSecrets: false |
Contributor
There was a problem hiding this comment.
thinking naming...maybe includeConfigSecrets?
also, do we want to doc a recommendation towards true/false? is the false default what we'd usually want or just for backcompat?
Contributor
Author
There was a problem hiding this comment.
yup, good idea. and yeah false the default just for backcompat
ryanartecona
approved these changes
Jan 27, 2025
JatinNanda
force-pushed
the
jatin/allow-eso-to-specify-postgres-password
branch
from
6d7ddf2 to
74430ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if external secrets are currently enabled, they don't let us specify the regular configuration secrets as a safeguard from clobbering.
this flag should let us both use an externalsecret for something like the postgres password and just use a regular secret for the other things like license key