Skip to content

Fix shouldIncludeConfigSecretsEnvVars output format#209

Merged
JatinNanda merged 1 commit intomainfrom
jatin/fix-eso-with-config-secrets-helper
Jan 28, 2025
Merged

Fix shouldIncludeConfigSecretsEnvVars output format#209
JatinNanda merged 1 commit intomainfrom
jatin/fix-eso-with-config-secrets-helper

Conversation

@JatinNanda
Copy link
Contributor

@JatinNanda JatinNanda commented Jan 28, 2025

need string output for this to work ._. (was previously always evaluating to 'true' since it was a non-empty string)

tested it this time with all combinations of inputs :')

@JatinNanda JatinNanda force-pushed the jatin/fix-eso-with-config-secrets-helper branch from d11dc79 to fc56943 Compare January 28, 2025 04:10
Copy link

@lukefoster11 lukefoster11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (looks great to me)

@JatinNanda JatinNanda merged commit 649239b into main Jan 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants