Skip to content

ExternalSecrets: Made SecretStoreRef and refreshInterval configurable via values.yaml#212

Merged
jjlgao merged 5 commits intotryretool:mainfrom
dmatviichuk:configurable-external-secrets
Mar 7, 2025
Merged

ExternalSecrets: Made SecretStoreRef and refreshInterval configurable via values.yaml#212
jjlgao merged 5 commits intotryretool:mainfrom
dmatviichuk:configurable-external-secrets

Conversation

@dmatviichuk
Copy link
Contributor

  • Made refreshInterval configurable via values.yaml.
  • Introduced configurable SecretStoreRef parameters.
  • Updated externalSecret.yaml to reference values from values.yaml.
  • Improved Helm chart flexibility for external secrets management.

@dmatviichuk dmatviichuk force-pushed the configurable-external-secrets branch from b9ac3b9 to 4ce2bee Compare February 13, 2025 00:50
@jjlgao
Copy link
Contributor

jjlgao commented Mar 6, 2025

Hi Dmytro, apologies as I just saw this. Just want to check before I take a look, did you have a use case you're aiming to solve for this change?

edit: took a look, appears pretty safe.

@dmatviichuk
Copy link
Contributor Author

Hi @jjlgao, we use Vault instead of AWS Secrets Manager as the secretStoreRef. Additionally, Retool secrets do not change frequently, so we want the ability to configure the refreshInterval.

@jjlgao
Copy link
Contributor

jjlgao commented Mar 6, 2025

Hi @jjlgao, we use Vault instead of AWS Secrets Manager as the secretStoreRef. Additionally, Retool secrets do not change frequently, so we want the ability to configure the refreshInterval.

Makes sense, thank you! I'll at least merge this now, but we won't release a new version for this, unless you feel that it's urgent for you, in which case if you're able to change the chart version in Chart.yaml in this PR, I can do a new release for you.

@dmatviichuk
Copy link
Contributor Author

@jjlgao Bumped Chart.yaml version and resolved the failing “Ensure values.yaml files match” check after syncing my branch with main. No rush at all — it’s fine to release it later.

@jjlgao jjlgao merged commit 3146ea5 into tryretool:main Mar 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants