ExternalSecrets: Made SecretStoreRef and refreshInterval configurable via values.yaml#212
Conversation
dmatviichuk
commented
Feb 13, 2025
- Made refreshInterval configurable via values.yaml.
- Introduced configurable SecretStoreRef parameters.
- Updated externalSecret.yaml to reference values from values.yaml.
- Improved Helm chart flexibility for external secrets management.
b9ac3b9 to
4ce2bee
Compare
|
Hi Dmytro, apologies as I just saw this. Just want to check before I take a look, did you have a use case you're aiming to solve for this change? edit: took a look, appears pretty safe. |
|
Hi @jjlgao, we use Vault instead of AWS Secrets Manager as the secretStoreRef. Additionally, Retool secrets do not change frequently, so we want the ability to configure the refreshInterval. |
Makes sense, thank you! I'll at least merge this now, but we won't release a new version for this, unless you feel that it's urgent for you, in which case if you're able to change the chart version in Chart.yaml in this PR, I can do a new release for you. |
|
@jjlgao Bumped Chart.yaml version and resolved the failing “Ensure values.yaml files match” check after syncing my branch with main. No rush at all — it’s fine to release it later. |