Skip to content

fix pdb spec templating for specs >1 field #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ryanartecona merged 2 commits into from
Oct 9, 2025
Merged

fix pdb spec templating for specs >1 field #253

ryanartecona merged 2 commits into from
Oct 9, 2025

Conversation

@ryanartecona
Copy link
Contributor

@ryanartecona ryanartecona commented Oct 3, 2025

Previously, a pdb spec like this would work

podDisruptionBudget:
  maxUnavailable: 1

but this wouldn't

podDisruptionBudget:
  maxUnavailable: 1
  unhealthyPodEvictionPolicy: AlwaysAllow

but only because that spec field was templated improperly.

@ryanartecona ryanartecona merged commit 5b65c24 into main Oct 9, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JatinNanda JatinNanda JatinNanda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanartecona @JatinNanda