Maintenance and various fixes July, 2025 #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves various issues with this ECS Template
Migrate template from deprecated
aws_launch_configuration
toaws_launch_template
. Credit to @marks for this change (AWS docs on deprecation) (5b5f34)Migrate EC2 launch type from
network_mode=bridge
tonetwork_mode=awsvpc
. Resolves issues withnetwork_mode=bridge
, establishes consistency with Cloudformation template and simplifies template. Credit to @marks for this change (ee7444)Updates the template to set sane cpu and memory defaults for both the EC2 and Fargate launch types. Replaces non-functional cluster autoscaling policy with a dual-metric (cpu & memory) autoscaling policy to scale tasks (with a TargetTrackingScaling policy_type) and managed scaling of the EC2 instances (0895fe)
Correct environment variables logic to set environment variables required for local Temporal deploy on other services only when deploying Temporal locally (8562d0)
Update template to support setting environment variables from AWS Secrets Manager. The functionally necessary variables—
POSTGRES_PASSWORD
,JWT_SECRET
,ENCRYPTION_KEY
—will now be set on tasks using secrets from values stored in AWS Secrets Manager. The template now supports setting additional optional environment variables similarly withvar.additional_secrets
(9b8841)Corrections to above changes (a3ca3b)
Successfully deployed with the following configuration with both
launch_type = "FARGATE"
&launch_type = "EC2"
: