This repository was archived by the owner on Aug 15, 2025. It is now read-only.
introduced obstacles for circular_hole_with_rect_pad#112
Closed
ShiboSoftwareDev wants to merge 1 commit intotscircuit:mainfrom
Closed
introduced obstacles for circular_hole_with_rect_pad#112ShiboSoftwareDev wants to merge 1 commit intotscircuit:mainfrom
ShiboSoftwareDev wants to merge 1 commit intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seveibar
approved these changes
Jun 15, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
fwiw i'm not sure if this is still used anywhere (I actually don't know)
Contributor
|
https://github.com/tscircuit/tscircuit-autorouter is the latest repo for the autorouter |
Contributor
Author
|
there is where we get the obstacles, it still imports from this repo: https://github.com/tscircuit/core/blob/5669e9fcad970272eb41c30bcfee41b13c53a22e/lib/utils/autorouting/getSimpleRouteJsonFromCircuitJson.ts#L17 |
Contributor
Author
|
@seveibar maybe move the function from here to core? |
Contributor
Author
Contributor
|
@ShiboSoftwareDev sorry yes makes sense to move this to core! Also note that route-json has a spec now, https://github.com/tscircuit/route-json/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.