Fix undefined in readable netlists and improve pin labels#23
Open
ysdy823 wants to merge 1 commit intotscircuit:mainfrom
Open
Fix undefined in readable netlists and improve pin labels#23ysdy823 wants to merge 1 commit intotscircuit:mainfrom
ysdy823 wants to merge 1 commit intotscircuit:mainfrom
Conversation
…ation - Fix scorePhrase to check word quality list before digit regex, so labels like "GPIO1" score 1.1 instead of 0.5 and appear in pin descriptions - Lower pin label threshold from > 1 to >= 1 to include custom pin names - Handle undefined footprint in COMPONENT_PINS header using filter(Boolean) - Handle undefined port.name fallback in COMPONENT_PINS mainPin - Handle undefined port.name and port.pin_number in getReadableNameForPin - Handle empty possibleNames array in generateNetName Closes tscircuit#4 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scorePhraseto check word quality list before digit regex, so labels like "GPIO1" score 1.1 (matching "GPIO") instead of 0.5, and appear in pin descriptions> 1to>= 1so custom pin names are includedfootprintin COMPONENT_PINS header (was showing "1kΩ undefined" when no footprint)port.namefallback in COMPONENT_PINSmainPinand ingetReadableNameForPinpossibleNamesarray ingenerateNetNameto prevent crashCloses #4
Test plan
🤖 Generated with Claude Code