feat: Add support for transistors#27
Merged
ShiboSoftwareDev merged 3 commits intotscircuit:mainfrom Nov 30, 2025
Merged
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
seveibar
reviewed
Nov 30, 2025
|
|
||
| - **Resistors** (`simple_resistor`) - Converted to SPICE R components | ||
| - **Capacitors** (`simple_capacitor`) - Converted to SPICE C components | ||
| - **Transistors** (`simple_transistor`) - Converted to SPICE Q components (BJT) |
Contributor
There was a problem hiding this comment.
BJTs are just one of hundreds of types of transistors, we need more data in the circuit json
seveibar
approved these changes
Nov 30, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Note my comment, mosfets, pnp, npn, n-channel, p-channel resistors all work totally differently, we need to support all of them! Lets make a checklist issue and test…
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for simple_transistor components within the
circuit-json-to-spice library. These components are now converted into SPICE BJT
(Q) elements.
Key changes:
• Implemented the logic for simple_transistor in lib/circuitJsonToSpice.ts.
• Added a new test file, tests/examples/switch.test.tsx, to validate the
transistor and switch functionality using the switch.json circuit.
• Updated README.md to include transistors in the list of supported components.