Skip to content

Fix SVG line stroke width scaling #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seveibar merged 2 commits into from
Nov 15, 2025
Merged

Fix SVG line stroke width scaling #81

seveibar merged 2 commits into from
Nov 15, 2025

Conversation

@seveibar
Copy link
Contributor

@seveibar seveibar commented Nov 15, 2025

Summary

  • scale projected line stroke widths by the transformation matrix when emitting SVG
  • update the line SVG test to assert scaled widths and add a stable snapshot for the transformed polylines

Testing

  • BUN_UPDATE_SNAPSHOTS=1 bun test tests/getSvgFromGraphicsObject.test.ts
  • bun test tests/getSvgFromGraphicsObject.test.ts
  • bunx tsc --noEmit

Codex Task

@vercel
Copy link

vercel bot commented Nov 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
graphics-debug Ready Ready Preview Comment Nov 15, 2025 2:17am

seveibar
seveibar commented Nov 15, 2025
View reviewed changes
lib/getSvgFromGraphicsObject.ts Outdated
svgWidth,
svgHeight,
)
const strokeScale = Math.hypot(matrix.a, matrix.b)
Copy link
Contributor Author

@seveibar seveibar Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const strokeScale = Math.hypot(matrix.a, matrix.b)
const strokeScale = Math.abs(matrix.a)

@seveibar seveibar mentioned this pull request Nov 15, 2025
Merged
@seveibar seveibar merged commit 824a94c into main Nov 15, 2025
3 checks passed
@seveibar seveibar deleted the codex/add-svg-snapshot-test-for-line-scaling branch November 15, 2025 02:17
@tscircuitbot
Copy link

tscircuitbot commented Nov 15, 2025

Thank you for your contribution! 🎉

PR Rating: ⭐⭐⭐
Impact: Major

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seveibar @tscircuitbot