Add optional DRC-disable flags to platformConfig#608
Merged
Conversation
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
netlistDrcChecksDisabled,routingDrcChecksDisabled, andplacementDrcChecksDisabledas optional boolean properties to thePlatformConfigTypeScript interface inlib/platformConfig.ts.platformConfigZod schema inlib/platformConfig.tsto accept and validate the three optional boolean flags.tests/platformConfig.drcChecksDisabled.test.tsthat verifies the new fields are accepted and preserved byplatformConfig.parse.README.mdandgenerated/PROPS_OVERVIEW.mdinclude the new fields and ran formatting and typechecks.Testing
bun test tests/platformConfig.drcChecksDisabled.test.tsand the test passed (1 pass, 0 fail).bun scripts/generate-component-types.ts,bun scripts/generate-manual-edits-docs.ts,bun scripts/generate-readme-docs.ts, andbun scripts/generate-props-overview.ts, and they completed successfully.bunx tsc --noEmitandbun run format, both completed successfully with no type errors and formatting applied.Codex Task