Windows: fix crash when rendering video #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Becuase stdlib.h was included, malloc was not declared anywhere. In C, using an undeclared function makes the compiler pretend that it's declared and has a signature of int func(); meaning that the return value is a 32 bit int and the parameters can be whatever. As a result of this, after the malloc call, the compiler would insert an instruction to sign extend the lower 32 bits of the RAX register into the upper 32 bits, which would of course create a pointer that is invalid in a lot of cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Becuase stdlib.h was not included, malloc was not declared anywhere. In C, using an undeclared function makes the compiler pretend that it's declared and has a signature of
int func();
meaning that the return value is a 32 bit int and the parameters can be whatever.
As a result of this, after the malloc call, the compiler would insert an instruction to sign extend the lower 32 bits of the RAX register into the upper 32 bits, which would of course create a pointer that is invalid in a lot of cases.
Fixes #137 though I only found this bug report after I already wrote all this other shit