Potential solution for DELETE_OLD on Windows #116
+31
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment in #111.
Changes:
_CRT_SECURE_NO_WARNINGS
if already defined (by cl.exe commands)MOVEFILE_WRITE_THROUGH
innob_rename
so the function doesn't return until the file is actually written--nob-delete-old
argument to tell the new nob to delete the old one, and run the new one async, so the old one can exit and release its own process handle