Fix errors when compiling with UNICODE macro, improvements to nob_win32_error_message, nob_mkdir_if_not_exists, nob_file_exists#35
Closed
KillerxDBr wants to merge 15 commits intotsoding:mainfrom
Closed
Conversation
…xists, using ascii versions of some functions
returning zero if file OR dir not found
Contributor
Author
|
I will refactor this one more time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored "nob_win32_error_message" to not return NULL if snprintf fail for some reason, it will always return a string now.
Made a proper Windows API version of "nob_mkdir_if_not_exists".
Finished "nob_file_exists", now it returns -1 in case of error. ("distinguish between "does not exists" and other errors")
Added a ifdef to minirent static function declarations to avoid compiler warnings when using nob.h in header mode:
nob cant be compiled on Windows if UNICODE/_UNICODE macros are enable, so i changed all windows API calls and structs to the A version, there was some using the macro (E.g. "CopyFile" instead of "CopyFileA" or "CopyFileW") versions, that changed if those macros are defined.
E.g.