3.0.0 #62
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,22 @@ | ||||||||||||||||||||||||||||||
| import path from "path"; | ||||||||||||||||||||||||||||||
| import {fileURLToPath} from "url"; | ||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. Inconsistent spacing in the import statement. Missing space after the comma following "path" and after the opening brace for "fileURLToPath".
Suggested change
|
||||||||||||||||||||||||||||||
| import {defineConfig} from "eslint/config"; | ||||||||||||||||||||||||||||||
|
Comment on lines
+2
to
+3
There was a problem hiding this comment. Inconsistent spacing in the import statement. Missing space after the comma following "path" and after the opening brace for "defineConfig".
Suggested change
|
||||||||||||||||||||||||||||||
| import tsParticlesESLintConfig from "@tsparticles/eslint-config"; | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| const __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| export default defineConfig([ | ||||||||||||||||||||||||||||||
| tsParticlesESLintConfig, | ||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||
| languageOptions: { | ||||||||||||||||||||||||||||||
| parserOptions: { | ||||||||||||||||||||||||||||||
| project: [path.resolve(__dirname, "src/tsconfig.json")], | ||||||||||||||||||||||||||||||
| tsconfigRootDir: __dirname, | ||||||||||||||||||||||||||||||
| sourceType: "module" | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||
|
Comment on lines
11
to
17
There was a problem hiding this comment. Fix sourceType placement (ESLint flat config). sourceType belongs under languageOptions, not parserOptions. Current placement may be ignored. - languageOptions: {
- parserOptions: {
- project: [path.resolve(__dirname, "src/tsconfig.json")],
- tsconfigRootDir: __dirname,
- sourceType: "module"
- }
- },
+ languageOptions: {
+ sourceType: "module",
+ parserOptions: {
+ project: [path.resolve(__dirname, "src/tsconfig.json")],
+ tsconfigRootDir: __dirname
+ }
+ },📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||
| rules: { | ||||||||||||||||||||||||||||||
| "no-console": "off" | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| ]); | ||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import tsParticlesESLintConfig from "@tsparticles/eslint-config"; | ||
| import { defineConfig } from "eslint/config"; | ||
|
|
||
| export default defineConfig([ | ||
| tsParticlesESLintConfig, | ||
| ]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
| "name": "@tsparticles/empty-template", | ||
| "version": "1.0.0", | ||
| "private": true, | ||
| "type": "module", | ||
| "author": "Matteo Bruni <[email protected]>", | ||
| "description": "tsParticles empty template", | ||
| "homepage": "https://particles.js.org", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,4 +1,16 @@ | ||||||||||
| import {loadParticlesTemplate} from "@tsparticles/webpack-plugin"; | ||||||||||
| import {fileURLToPath} from "url"; | ||||||||||
|
Comment on lines
+1
to
+2
There was a problem hiding this comment. Inconsistent spacing in the import statement. Missing space after the comma following "path" and after the opening brace for "fileURLToPath".
Suggested change
|
||||||||||
| import fs from "fs-extra"; | ||||||||||
| import path from "path"; | ||||||||||
|
|
||||||||||
| const __filename = fileURLToPath(import.meta.url), | ||||||||||
| __dirname = path.dirname(__filename), | ||||||||||
| rootPkgPath = path.join(__dirname, "package.json"), | ||||||||||
| pkg = await fs.readJson(rootPkgPath); | ||||||||||
|
|
||||||||||
| export default loadParticlesTemplate({ | ||||||||||
| moduleName: "empty", | ||||||||||
| templateName: "Empty", | ||||||||||
| version: pkg.version, | ||||||||||
| dir: __dirname | ||||||||||
| }); | ||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,7 +1,8 @@ | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| "name": "@tsparticles/cli", | ||||||||||||||||||||||
| "version": "3.0.8", | ||||||||||||||||||||||
| "license": "MIT", | ||||||||||||||||||||||
| "type": "module", | ||||||||||||||||||||||
| "bin": { | ||||||||||||||||||||||
| "tsparticles-cli": "dist/cli.js" | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
|
|
@@ -21,66 +22,60 @@ | |||||||||||||||||||||
| "compile:ci": "pnpm run build:ts", | ||||||||||||||||||||||
| "build:ts": "pnpm run build:ts:cjs", | ||||||||||||||||||||||
| "build:ts:cjs": "tsc -p src", | ||||||||||||||||||||||
| "test": "vitest run", | ||||||||||||||||||||||
| "build": "pnpm run clear:dist && pnpm run prettify:src && pnpm run lint && pnpm run compile && pnpm run circular-deps && pnpm run prettify:readme && chmod +x dist/cli.js && chmod +x dist/build/build.js && chmod +x dist/create/create.js && chmod +x dist/create/preset/preset.js", | ||||||||||||||||||||||
| "build:ci": "pnpm run clear:dist && pnpm run prettify:ci:src && pnpm run lint:ci && pnpm run compile:ci && pnpm run prettify:ci:readme", | ||||||||||||||||||||||
| "clear:dist": "rimraf ./dist", | ||||||||||||||||||||||
| "prepack": "pnpm run build", | ||||||||||||||||||||||
| "version": "node scripts/postversion.js && git add files/empty-project/package.json" | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "dependencies": { | ||||||||||||||||||||||
| "@tsparticles/eslint-config": "^3.0.5", | ||||||||||||||||||||||
| "@tsparticles/prettier-config": "^3.0.1", | ||||||||||||||||||||||
| "@tsparticles/tsconfig": "^3.0.5", | ||||||||||||||||||||||
| "@tsparticles/webpack-plugin": "^3.0.5", | ||||||||||||||||||||||
| "commander": "^14.0.0", | ||||||||||||||||||||||
| "eslint": "^9.34.0", | ||||||||||||||||||||||
| "eslint-config-prettier": "^10.1.8", | ||||||||||||||||||||||
| "eslint-plugin-jsdoc": "^54.1.1", | ||||||||||||||||||||||
| "eslint-plugin-prettier": "^5.5.4", | ||||||||||||||||||||||
| "eslint-plugin-tsdoc": "^0.4.0", | ||||||||||||||||||||||
| "fs-extra": "^11.3.1", | ||||||||||||||||||||||
| "klaw": "^4.1.0", | ||||||||||||||||||||||
| "lookpath": "^1.2.3", | ||||||||||||||||||||||
| "madge": "^8.0.0", | ||||||||||||||||||||||
| "path-scurry": "^2.0.0", | ||||||||||||||||||||||
| "prettier": "^3.6.2", | ||||||||||||||||||||||
| "prettier-plugin-multiline-arrays": "^4.0.3", | ||||||||||||||||||||||
| "prompts": "^2.4.2", | ||||||||||||||||||||||
| "rimraf": "^6.0.1", | ||||||||||||||||||||||
| "typescript": "^5.9.2", | ||||||||||||||||||||||
| "typescript-eslint": "^8.41.0", | ||||||||||||||||||||||
| "webpack": "^5.101.3" | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "devDependencies": { | ||||||||||||||||||||||
| "@babel/core": "^7.28.3", | ||||||||||||||||||||||
| "@tsparticles/cli": "^2.3.3", | ||||||||||||||||||||||
| "@tsparticles/engine": "^3.9.1", | ||||||||||||||||||||||
|
||||||||||||||||||||||
| "@babel/core": "^7.28.3", | |
| "@tsparticles/cli": "^2.3.3", | |
| "@tsparticles/engine": "^3.9.1", | |
| "@babel/core": "^7.28.3", | |
| "@tsparticles/engine": "^3.9.1", |
🤖 Prompt for AI Agents
package.json around lines 57-59: remove the package's own name from
devDependencies (the self-dependency entry) so the project does not list itself
as a devDependency; delete that dependency line, save package.json, then run
your package manager (npm install or yarn install) to update node_modules and
the lockfile and verify package.json remains valid.
There was a problem hiding this comment.
🛠️ Refactor suggestion
"main" points to eslint.config.js; set it to the CLI entry or drop it.
Current value breaks consumers importing the package.
- "main": "eslint.config.js",
+ "main": "dist/cli.js",
+ "exports": {
+ ".": "./dist/cli.js",
+ "./package.json": "./package.json"
+ },📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "main": "eslint.config.js", | |
| // before (around line 79) | |
| - "main": "eslint.config.js", | |
| // after | |
| "main": "dist/cli.js", | |
| "exports": { | |
| ".": "./dist/cli.js", | |
| "./package.json": "./package.json" | |
| }, |
🤖 Prompt for AI Agents
In package.json around line 79, the "main" field incorrectly points to
eslint.config.js which breaks consumers; update the "main" field to point to
your package's actual runtime/CLI entry (e.g., the built CommonJS entry like
"lib/index.js" or the published CLI entry), or remove the "main" field entirely
if the package is only a CLI and you expose binaries via "bin"; ensure the
chosen path exists in the published package and matches your build/output.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pnpm action versions are inconsistent between the two jobs. Job "main" uses "@v4" (line 22) while job "pr" uses "@V3" (line 60). They should use the same version for consistency.