Configuration from Web Browser by sebcaps · Pull Request #73 · tspopp/AquaMQTT

sebcaps · 2025-03-30T13:58:42Z

This PR cancel and replace #71.
Even the purpose is the same, implementation is different and use a rest API architecture for better/easier extensibility.
Other changes are :

new webserver library (ESPAsyncWebServer vs esp library)
html refactoring
fix feature request: Web interface #55 , fix-partially feature(wifimanager): get rid of configuration files #63

…to OnlineConfig

tspopp

Overall this looks very solid 👍 I have not installed this yet, but will most probably try it out the next days. There are a few spelling things which we can resolve later. I did a first review of the code and I believe I like what I see and how you added this to the codebase.

I think we should prepare this PR to remove the entire Configuration from the firmware, so we will be able to provide firmware images which does not contain any custom configuration.

Still, I do not undestand the need for the javascript and the css files. If you could provide some quick explanation and background and maybe why you chosen that, would be very helpful.

Actually I thought about going along with https://github.com/tzapu/WiFiManager. What was the reason for not taking this library into accout?

AquaMQTT/README.md

AquaMQTT/data/index.html

AquaMQTT/include/handler/Web.h

AquaMQTT/src/config/config.cpp

AquaMQTT/src/main.cpp

Co-authored-by: Thomas Popp <66408890+tspopp@users.noreply.github.com>

sebcaps · 2025-03-31T21:16:14Z

Hello,
All comments taken into account.
Actually, I did not know WifiManager and so recreate a similar and light implementation for wifi settings. (eg no static IP...)
From what I see it can handle more parameter than just wifi.
Well let's say I somehow reinvented the wheel.

…popp#75) * fix(next): fix heating element enabled switch * chore(version): bump version to v1.7.1

…see)

)

…pp#88)

* added a guide inside of HOMEASSISTANT.md` to setup a climat entity * added custom climate card showcase images * Updated HOMEASSISTANT.md with 3 showcase images from ./img

…heatpumps The mLastStateUpdate variable was declared as time_t (signed integer) while being compared with millis() return values (unsigned long). This caused incorrect behavior after millis() exceeded the maximum signed integer value (2,147,483,647ms / ~24.8 days), causing time updates to stop being sent. Changed mLastStateUpdate to unsigned long to match the type returned by millis() and ensure proper overflow handling in time comparisons.

…opp#100)

sebcaps · 2025-12-21T11:33:19Z

Hello, any chance for this PR to be merged ? ;-)

tspopp · 2025-12-21T20:45:33Z

First I think you need to rebase. I am quite open to merge this, but as suggested I think it would be nice to get rid of the entire configuration.h file. Don't you agree? I thought maybe you will go in that direction, but you were running into an "out of time" error ;)

Co-authored-by: Thomas Popp <66408890+tspopp@users.noreply.github.com>

…piStyle

sebcaps · 2025-12-22T18:22:54Z

Hello,
I rebase my code to comply with all the improvements. Actually I did not implement all parameters on purpose.
Some as MQTT_FILTER_TEMPERATURE, KALMAN_MEA_E.... sound to me quite unusual to be redefined.
Anyway, I will add them and propose a complete interface to avoid manual manipulation of configuration.h file.

tspopp · 2026-01-18T06:42:38Z

Hey, sorry for the long delay, been quite busy these days. I try go give this a test run soon and provide comments.

phil-schneider · 2026-01-18T13:02:49Z

I think this would be a real changer for this project.
People would not need to checkout git, compile themself and so one.
Currently every user needs to compile it themself.
With this: The user can upload a precompiled version. And then adjust the settings via a webinterface.
Simular to WLED.

sebcaps · 2026-01-18T17:23:13Z

New version with all the parameters in progress

Almost good from a web / api perspective.
Will need more testing from esp32 perspective. Not a precise idea on how-to without connecting to a real device.
In addition I think it would be good to clamp some parameter like Kalman filter params, update intervalls; but no clue on limits.

Any hints about these two points ?

tspopp · 2026-01-19T20:33:37Z

Will need more testing from esp32 perspective. Not a precise idea on how-to without connecting to a real device.

Have not looked yet into the code, but if you can move all the business logic unrelated to the Arduino framework into a separate internal library, you can use the native platformio environment to write and run unittests. I did the same for a few protocol test I needed to write back then. Maybe this helps?

In addition I think it would be good to clamp some parameter like Kalman filter params, update intervalls; but no clue on limits.

Maybe me make these kalman parameters just const, not changeable through the web-if. Only very advanced users will change them anyway. What do you think?

sebcaps · 2026-01-25T16:18:30Z

Will need more testing from esp32 perspective. Not a precise idea on how-to without connecting to a real device.

Have not looked yet into the code, but if you can move all the business logic unrelated to the Arduino framework into a separate internal library, you can use the native platformio environment to write and run unittests. I did the same for a few protocol test I needed to write back then. Maybe this helps?

Will have a look to unittests, hope I'll manage to handle them...

In addition I think it would be good to clamp some parameter like Kalman filter params, update intervalls; but no clue on limits.

Maybe me make these kalman parameters just const, not changeable through the web-if. Only very advanced users will change them anyway. What do you think?

Actually, I added all parameters from Configuration.h (except WATCHDOG_TIMEOUT_MS, WIFI_RECONNECT_CYCLE_S, MQTT_MAX_TOPIC_SIZE, MQTT_MAX_PAYLOAD_SIZE which are unlikely to change) to almost remove the entire Configuration from the firmware.
I will re-add MQTT_FILTER_TEMPERATURE_NOISE, KALMAN_MEA_E, KALMAN_EST_E and KALMAN_Q.

Do you envision any other settings that are not very relevant from web config ?

sebcaps added 7 commits March 2, 2025 11:05

first commit

4b5ed7f

addMqttConfigHandling

9cd5a81

WebConfiguration

a549034

remove html file

e1f9e21

Delete AquaMQTT/data/test.html

11e5bb1

Merge branch 'OnlineConfig' of https://github.com/sebcaps/AquaMQTT in…

71ccac4

…to OnlineConfig

finalversion

9eeca40

sebcaps mentioned this pull request Mar 30, 2025

Configuration from Web Browser #71

Closed

tspopp added 2 commits March 30, 2025 20:56

doc(readme): added discord for community and pcb trading possibility

5192d75

doc(readme): fix discord link

6a3146b

tspopp requested changes Mar 30, 2025

View reviewed changes

sebcaps and others added 2 commits March 31, 2025 22:46

Fix PR comments

aa3c7b2

Update AquaMQTT/src/main.cpp

b8ec1e5

Co-authored-by: Thomas Popp <66408890+tspopp@users.noreply.github.com>

sebcaps requested a review from tspopp March 31, 2025 21:19

tspopp and others added 15 commits April 9, 2025 08:48

doc(readme): fix discord link

72fad6b

fix(next): fix option allow heat element and pv mode heat element (ts…

06d8c3b

…popp#75) * fix(next): fix heating element enabled switch * chore(version): bump version to v1.7.1

fix(next): fix parsing of operation type (tspopp#78)

442fc5c

fix(aquamqtt): provide proper boiler brand to mqtt (tspopp#79)

2755433

fix(odyssee): fix setting operation type and mode

073905f

fix(next/odyssee): proper date overrides

946f047

test(protocol): unittest for hmi protocol overrides (next/legacy/odys…

53713e9

…see)

chore(version): bump to v1.7.2

7f5f8b5

doc(devices): updated list of proofen devices

0aa134f

feat(protocol): parse and provide software version attributes (tspopp#81

1a6dfcf

)

fix(serial): allow serial configuration from configuration file (tspo…

95d171b

…pp#88)

doc(homeassistant): added guide to setup climate entity (tspopp#89)

b9317c1

* added a guide inside of HOMEASSISTANT.md` to setup a climat entity * added custom climate card showcase images * Updated HOMEASSISTANT.md with 3 showcase images from ./img

chore(release): bump version to v1.8.0

238c8de

doc(readme): incorporated various feedback, add thermor aeromax rt+

61e5db9

feat(climate): add climate component to home-assistant discovery (tsp…

fe230df

…opp#100)

sebcaps and others added 8 commits December 22, 2025 09:10

first commit

b7b60a7

addMqttConfigHandling

f68af07

WebConfiguration

85571a9

remove html file

e8d5ffe

finalversion

ee13e8f

Fix PR comments

14e6242

Update AquaMQTT/src/main.cpp

de879a4

Co-authored-by: Thomas Popp <66408890+tspopp@users.noreply.github.com>

Merge branch 'ApiStyle' of https://github.com/sebcaps/AquaMQTT into A…

0608f2e

…piStyle

Conversation

sebcaps commented Mar 30, 2025

Uh oh!

tspopp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebcaps commented Mar 31, 2025

Uh oh!

sebcaps commented Dec 21, 2025

Uh oh!

tspopp commented Dec 21, 2025

Uh oh!

sebcaps commented Dec 22, 2025

Uh oh!

tspopp commented Jan 18, 2026

Uh oh!

phil-schneider commented Jan 18, 2026

Uh oh!

sebcaps commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tspopp commented Jan 19, 2026

Uh oh!

sebcaps commented Jan 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sebcaps commented Jan 18, 2026 •

edited

Loading