Open
Conversation
added 11 commits
June 14, 2016 20:00
|
Rebase against latest. Can you squash where necessary? Can you take out the version part so it can be changed when the release is cut? |
Owner
|
As you can tell, I don't spend a lot of time on my Chinese GitHub projects anymore. Thanks for contributing! This is a great start. It will need some work before it's ready to merge. I'm happy to work with you on the things that need to be changed.
I'd suggest using a resource like these three charts to create a regular expression pattern like the Zhuyin and Pinyin ones in Zhon. Here is a short example of characters = 'bpmfdtnlgkhwzcsjaeiouy'
marks = '123456'
syl = syllable = (
'(?:'
'(?:(?:[gk]w|[bpmfdtnlzcsgkhwj])?aa)|'
'(?:(?:[gk]w|ng|[bpmfdtnlzcsgkhwj])?ai)'
')[{marks}]'
).format(marks=marks) |
Author
|
Awesome! Thanks for the help! Will get to it when I can :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For implementation in dragonmapper...