Skip to content

Apply changes to geertsma branch#23

Open
gabrielserrao wants to merge 1 commit intomainfrom
geertsma
Open

Apply changes to geertsma branch#23
gabrielserrao wants to merge 1 commit intomainfrom
geertsma

Conversation

@gabrielserrao
Copy link
Collaborator

Implemented geertsma, both for disc and nucleous of strain

@prisae
Copy link
Member

prisae commented Mar 12, 2025

Thanks Gabriel, this is great! I will have a look over the weekend or next week.

Currently all tests fail, primarily due to flak8 (code style). I can sort that out, but if you want, you can also tackle it. Locally, just run make flake8, and it will lint your code and give you feedback.

You can also run locally make pytest, to see if the actual tests pass.

@prisae
Copy link
Member

prisae commented Mar 12, 2025

Also, any code added to dageo (not to the examples) will have to be covered by tests. We can work on that together.

@prisae prisae mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants