Development/robert2024 hielke adds daalder#51
Development/robert2024 hielke adds daalder#51hwalinga wants to merge 23 commits intoDevelopment/Robert2024from
Conversation
Unit Test Results (x64-linux) 1 files 1 suites 0s ⏱️ Results for commit 2a892fc. ♻️ This comment has been updated with latest results. |
Unit Test Results (x64-windows) 1 files 1 suites 1s ⏱️ Results for commit 2a892fc. ♻️ This comment has been updated with latest results. |
| if (added_traces.contains(r.pk)) { | ||
| bool ldot_algorithm::add_trace(inputdata& id, const sul_response& r) { | ||
| int pk = r.GET_ID(); | ||
| if (my_sul->added_traces.contains(pk)) { |
There was a problem hiding this comment.
you could write a contains() method in your sul to encapsulate the added_traces
| return false; | ||
| } | ||
| added_traces.insert(r.pk); | ||
| my_sul->added_traces.insert(pk); |
| std::shared_ptr<sqldb_sul> my_sqldb_sul; | ||
|
|
||
| public: | ||
| explicit sqldb_sul_random_oracle(std::unique_ptr<sul_base>& sul) : base_oracle(sul) { |
There was a problem hiding this comment.
why did explicit disappear here? And why was it there in the first place?
| std::shared_ptr<sqldb_sul> my_sqldb_sul; | ||
|
|
||
| public: | ||
| explicit sqldb_sul_regex_oracle(std::unique_ptr<sul_base>& sul) : base_oracle(sul) { |
| return sul_response(); | ||
| } | ||
| auto rec = rec_maybe.value(); | ||
| return sul_response(rec.type, rec.pk, std::move(rec.trace)); |
There was a problem hiding this comment.
you could summarize the above line with this one
|
Well done Hielke. I have a few minor comments (nitpicking), but that's a matter of a few minutes. You can merge then |
|
Also merged with Development/robert2024 |
|
Merged with #55 |
2 participants
No description provided.