Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a name/origin field to TickSequence and propagates it through core helpers, tests, and the Carla importer so sequences can be identified more easily (e.g., in logs/debugging).
Changes:
- Add
nameas a constructor property onTickSequenceand add anameparameter toIterable.asTickSequence(...). - Update Carla tick loading to assign a descriptive
TickSequencename per ego vehicle. - Update
stars-coreTickSequencetests and changelog to reflect the new parameter/property.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| stars-importer-carla/src/main/kotlin/tools/aqua/stars/importer/carla/carlaDataFileHandling.kt | Assigns a descriptive name when creating TickSequences for each ego. |
| stars-core/src/main/kotlin/tools/aqua/stars/core/evaluation/TickSequence.kt | Introduces name as a constructor property; extends asTickSequence with name. |
| stars-core/src/test/kotlin/tools/aqua/stars/core/evaluation/TickSequenceTest.kt | Updates direct TickSequence construction for new required name argument. |
| stars-core/src/test/kotlin/tools/aqua/stars/core/evaluation/TickSequenceTestForward.kt | Adds name argument to TickSequence test instances. |
| stars-core/src/test/kotlin/tools/aqua/stars/core/evaluation/TickSequenceTestBackward.kt | Adds name argument to TickSequence test instances. |
| CHANGELOG.md | Notes the addition of the name property. |
Comments suppressed due to low confidence (1)
stars-core/src/main/kotlin/tools/aqua/stars/core/evaluation/TickSequence.kt:48
TickSequenceis a public class instars-core, and adding a new required constructor parameter (name) is a source/binary breaking API change for any downstream callers. If backwards compatibility is desired, consider givingnamea default value (e.g.,"") and/or adding a secondary constructor matching the previous signature so existing code can keep compiling without changes.
class TickSequence<T : TickDataType<*, T, *, *>>(
val name: String,
val bufferSize: Int = 100,
val iterationOrder: IterationOrder = IterationOrder.FORWARD,
val iterationMode: IterationMode = IterationMode.FULL_FRAME,
private val getNextValue: () -> T?,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dominikmaeckel
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.