Skip to content

Add name field to TickSequence#316

Merged
tillschallau merged 3 commits intomainfrom
add-name-to-ticksequence
Feb 10, 2026
Merged

Add name field to TickSequence#316
tillschallau merged 3 commits intomainfrom
add-name-to-ticksequence

Conversation

@tillschallau
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a name/origin field to TickSequence and propagates it through core helpers, tests, and the Carla importer so sequences can be identified more easily (e.g., in logs/debugging).

Changes:

  • Add name as a constructor property on TickSequence and add a name parameter to Iterable.asTickSequence(...).
  • Update Carla tick loading to assign a descriptive TickSequence name per ego vehicle.
  • Update stars-core TickSequence tests and changelog to reflect the new parameter/property.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
stars-importer-carla/src/main/kotlin/tools/aqua/stars/importer/carla/carlaDataFileHandling.kt Assigns a descriptive name when creating TickSequences for each ego.
stars-core/src/main/kotlin/tools/aqua/stars/core/evaluation/TickSequence.kt Introduces name as a constructor property; extends asTickSequence with name.
stars-core/src/test/kotlin/tools/aqua/stars/core/evaluation/TickSequenceTest.kt Updates direct TickSequence construction for new required name argument.
stars-core/src/test/kotlin/tools/aqua/stars/core/evaluation/TickSequenceTestForward.kt Adds name argument to TickSequence test instances.
stars-core/src/test/kotlin/tools/aqua/stars/core/evaluation/TickSequenceTestBackward.kt Adds name argument to TickSequence test instances.
CHANGELOG.md Notes the addition of the name property.
Comments suppressed due to low confidence (1)

stars-core/src/main/kotlin/tools/aqua/stars/core/evaluation/TickSequence.kt:48

  • TickSequence is a public class in stars-core, and adding a new required constructor parameter (name) is a source/binary breaking API change for any downstream callers. If backwards compatibility is desired, consider giving name a default value (e.g., "") and/or adding a secondary constructor matching the previous signature so existing code can keep compiling without changes.
class TickSequence<T : TickDataType<*, T, *, *>>(
    val name: String,
    val bufferSize: Int = 100,
    val iterationOrder: IterationOrder = IterationOrder.FORWARD,
    val iterationMode: IterationMode = IterationMode.FULL_FRAME,
    private val getNextValue: () -> T?,

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tillschallau tillschallau enabled auto-merge (squash) February 10, 2026 14:54
@tillschallau tillschallau merged commit d8fdefd into main Feb 10, 2026
26 checks passed
@tillschallau tillschallau deleted the add-name-to-ticksequence branch February 10, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants