Skip to content

Speed up pfield computation#267

Draft
wesselvannierop wants to merge 12 commits intomainfrom
feature/pfield-clean
Draft

Speed up pfield computation#267
wesselvannierop wants to merge 12 commits intomainfrom
feature/pfield-clean

Conversation

@wesselvannierop
Copy link
Collaborator

I wanted to fix #192 but this seemed to be quite a challenge with the current infrastructure. So I ended up speeding up the pfield computation itself through parallelization. This was previously not possible because it used varying frequency bins based on every transmit. Now it uses the same amount for all transmits, based on the worst case. In some cases the speedup is over 10x!

Additionally, I cleaned up variable naming inside the pfield func.

Still need to test it a bit more.

@wesselvannierop wesselvannierop self-assigned this Feb 17, 2026
@wesselvannierop wesselvannierop added ultrasound Improvements regarding ultrasound reconstruction pipeline efficiency Improvements made regarding code or tests efficiency labels Feb 17, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/pfield-clean

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 93.68421% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
zea/scan.py 40.00% 5 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@tristan-deep tristan-deep added this to the v0.0.11 milestone Mar 3, 2026
@tristan-deep tristan-deep modified the milestones: v0.0.11, v0.0.12 Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

efficiency Improvements made regarding code or tests efficiency ultrasound Improvements regarding ultrasound reconstruction pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce recomputing pfield when set_transmits is used.

2 participants