Receptionist find empty seat2 #1316
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthijsBurgh
force-pushed
the
receptionist_find_empty_seat2
branch
from
92ee2ef to
d1b9645
Compare
Contributor
PetervDooren
left a comment
PetervDooren
left a comment
There was a problem hiding this comment.
No real functional changes here. Added some general tips but I dont think these changes add value just yet.
Comment on lines
+51
to
+56
| """ | ||
| Iterate over all seat-type objects and check that their 'on-top-of' volume is empty | ||
| That can be done with an Inspect and then query for any Entities inside that volume. | ||
| If there are none, then the seat is empty | ||
| """ | ||
|
|
Contributor
There was a problem hiding this comment.
Add information on the arguments in the docstring. What do the arguments mean?
Comment on lines
+41
to
+42
| # This is needed because the head is not entirely still when the look_at_point function finishes | ||
| time.sleep(0.5) |
Contributor
There was a problem hiding this comment.
This is no longer true for Hero. It was a hack for Amigo
| from .world_model import look_at_segmentation_area | ||
|
|
||
|
|
||
| class LookAtEntity(smach.State): |
Contributor
There was a problem hiding this comment.
this function is more at place in world_model.py
| @@ -0,0 +1,177 @@ | |||
| #! /usr/bin/env python | |||
Contributor
There was a problem hiding this comment.
This file is not needed unless you want to test this version and the original side by side. I think it was originally created as a tournament hack. But now you may feel free to make changes to find_empty_seat.py
|
|
||
| class PeopleInSeatDesignator(ds.Designator): | ||
| def __init__(self, robot, seat: Entity, room: Entity = None, name=None): | ||
| def __init__(self, robot, seat: Entity, volume: Entity = None, name=None): |
Contributor
There was a problem hiding this comment.
- please add a docstring to define what the arguments mean.
- why switch from room to volume. Volume is more general but it is so general is is meaningless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.