fix(buildsettings): add missing global accent color name build setting for apps #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
fortmarek
approved these changes
Apr 1, 2025
| struct BuildSettingProviderTests { | ||
|
|
||
| @Test("Target settings", arguments: [ | ||
| TestParameters( |
damien-rivet
force-pushed
the
fix/919-add-missing-global-accent-color-name-build-setting-for-apps
branch
from
f519d3d to
be7d9da
Compare
pepicrft
approved these changes
Apr 7, 2025
damien-rivet
deleted the
fix/919-add-missing-global-accent-color-name-build-setting-for-apps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #919
Short description 📝
This PR adds the missing Global Accent Color Name (
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME) build setting for App targets.Solution 📦
I followed the trail of
ASSETCATALOG_COMPILER_APPICON_NAMEto find where to add the missing build setting.Implementation 👩💻👨💻
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAMEto App default build settingsBuildSettingsProvidertests with Swift Testing