feat: implement support for the App Clip's URL #927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns-vasilev
changed the title
fortmarek
approved these changes
Apr 14, 2025
Member
fortmarek
left a comment
fortmarek
left a comment
There was a problem hiding this comment.
Changes look good! You'll need to update the commit message and the PR message for the conventional check to pass, so this gets auto-released. We can merge this once the CI is green.
ns-vasilev
force-pushed
the
feature/app-clips
branch
from
7926508 to
f762502
Compare
ns-vasilev
changed the title
2 tasks
|
Can we trigger CI for this? Is that all that's outstanding? |
Member
|
Sorry for taking a bit longer here – and thanks again for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
Implement support for the App Clip's URL
Solution 📦
Added a new
appClipInvocationURLStringparameter to XCScheme+LaunchAction.swift to handle the App Clip's URL.