Skip to content

Commit History Analysis

Marcel Skalski edited this page Mar 25, 2025 · 3 revisions

Directly Resolved Faults

  • F5a: Resolved with commit change to mysql ts-train - April 29, 2022

    The ts-train-service now correctly perform an isPresent()-check instead of the previous incorrect null-check:

    image

  • F5b: Resolved with commit fix station - Jul 13, 2022

    The ts-station-service now correctly perform an isPresent()-check instead of the previous incorrect null-check:

    image

  • F9a and F9b: Resolved with commit fix Order/Orderother about date type bug - July 28, 2022

    Instead of receiving a Date object as a path variable, the ts-order-service and ts-order-other-service now correctly accept a string object as a path variable, which is then correctly transformed into the desired Date object:

    image

  • F13a: Resolved with commit optimize travel and seat loop dependency - July 21, 2022

    The ts-basic-service now no longer generates an empty string that will be used as a path variable for the ts-price-service, and instead correctly returns an unsuccessful response beforehand:

    image

  • F16a and F16b: Resolved with commit modify timeout value - June 8, 2020

    The timeout values defined in the controller classes of the ts-preserve-service and ts-preserve-other-service were increased from 5000 milliseconds to 20000 milliseconds to resolve the insufficient timeout value:

    image

  • F27b: Resolved with commit Hd mysql - June 12, 2022

    All faults related to F27 stemmed from failing to check whether a string could be converted to a UUID before attempting the conversion, leading to a NumberFormatException. In the ts-security-service, this fault was addressed by changing the data type of identifiers from UUID to string, eliminating the need for conversion:

    image

  • F27c: Resolved with commit change to mysql ts-auth - April 29, 2022

    All faults related to F27 stemmed from failing to check whether a string could be converted to a UUID before attempting the conversion, leading to a NumberFormatException. In the ts-auth-service, this fault was addressed by changing the data type of identifiers from UUID to string, eliminating the need for conversion:

    image

Indirectly Resolved Faults

  • F6: Indirectly resolved with commit optimize travel and seat loop dependency - July 21, 2022

    F6 involved a faulty null-check, as the method getRouteByRouteId() within the ts-travel-service incorrectly returned a new route object with default (uninitialized) values when no matching route was found. While this method remains unaltered in version 1.0.0, the service implementation no longer invokes it, thereby avoiding the fault as a byproduct:

    image

  • F11: Indirectly resolved with commit remove hystrix - July 19, 2020

    The mismatch between two different data types (HTTPEntity vs. ResponseEntity<Response>) is no longer present in version 1.0.0. However, the commit which resolved the fault deleted all occurrences of fallback methods. Therefore, whether this fault was recognized and intentionally addressed by its developers or resolved as a byproduct of broader changes remains unknown:

    image

  • F13b and F13c: Indirectly resolved with commit delete service ticketinfo - December 31, 2021

    F13b and F13c involved passing an empty string variable as a path to the ts-ticketinfo-service. The ts-ticketinfo-service was removed entirely with this commit, removing the request made to this service and indirectly resolving these faults in the ts-travel-service (F13b) and ts-travel2-service (F13c).

  • F20a and F20b: Indirectly resolved with commit fix bugs - July 26, 2022

    An unhandled IndexOutOfBoundsException occurred in the ts-order-service (F20a) and ts-order-other-service (F20b) due to unchecked access to an empty list of stations returned by the requested ts-station-service. Within both services, this request to the ts-station-service has been commented out, which resolved the fault in the process of this change. It remains unclear whether this request was commented out specifically to address this fault or was part of broader service changes:

    image

Partially Resolved Faults

  • F4a: Partially resolved with commit Station food (January 4, 2022) and Fix food service (July 27, 2022)

    F4a involved an incorrect null-check with a repository method that never returns null. The ts-food-map-service, which previously contained multiple instance of this fault, was removed. Its functionality was split into two new services: ts-train-food-service and ts-station-food-service with commit Station food (January 4, 2022).

    In the ts-train-food-service, the fault was addressed , as the repository method has been altered with commit Fix food service (July 27, 2022) to be able to return null, as it returns a single object instead of a list:

    image

    However, in the ts-station-food-service, the method containing the fault remains unchanged from its previous implementation in the ts-food-map-service:

    image

    Consequently, F4a has only been partially resolved.

  • F27e and F27f: Partially resolved with commit Cqq mysql - June 10, 2022

    All faults related to F27 stemmed from failing to check whether a string could be converted to a UUID before attempting the conversion, leading to a NumberFormatException. In the ts-order-other-service (F27e) and ts-order-service (F27f), this fault occurred multiple times within the same service. While most of these occurrences have been resolved by changing the data type of identifiers from UUID to string, eliminating the need for conversion:

    image

    the deleteOrder() method within both services remains unresolved:

    image

    Consequently, F27e and F27f have only partially been resolved.

Clone this wiki locally