Take rebase options from command-line#156
Merged
tummychow merged 4 commits intotummychow:masterfrom Mar 7, 2025
Merged
Conversation
Assigning an author to begin with slightly simplifies adding test commits, and will also support workflows that actually run git to create new commits.
No production code change. Just test the current behaviour before we change it.
Options will be read from all arguments after `--`, and will be passed to git rebase as-is. Throws an error if --and-rebase is not also specified.
Owner
|
thanks, nice work. unfortunate that we have to chdir during a test. maybe we should be invoking git-rebase with -C... not a blocker for this pr. are there more things you wanted to send prs for before i cut v0.7.0? |
Contributor
Author
|
Oh, I'm just noodling along. The only feature I was interested in was config for one-fixup-per-commit. I have no agenda otherwise aside from "I've learned how to work within the repo, so why not clean up some old issues". If you want to direct me toward something, whether it's feature work or infrastructure, please do, but I'm not interested in holding up a release! I appreciate you indulging me. I'm having a good time. |
Contributor
Author
|
Was not aware of |
blairconrad
added a commit
to blairconrad/git-absorb
that referenced
this pull request
Mar 8, 2025
From [a suggestion made in tummychow#156](tummychow#156 (comment)). In addition to ensuring we're running from the right directory in production, makes it easier to write tests that rebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88.