Impl ReplyTree data layer#1044
Impl ReplyTree data layer#1044joelmuraguri wants to merge 6 commits intojoel/expose-post-thread-parent-urifrom
Conversation
joelmuraguri
changed the base branch from
main
to
joel/expose-post-thread-parent-uri
Summary of ChangesHello @joelmuraguri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements the data layer for ReplyTree, which is a new way to represent threaded conversations. The changes introduce TimelineItem.ReplyTree and ReplyNode data classes and update the TimelineRepository to build these trees from fetched post data. The review identifies a critical bug where ReplyTree items are incorrectly filtered out from the timeline view, and a performance issue in the recursive function used to build the reply tree. Suggestions are provided to fix both issues.
ui/timeline/src/commonMain/kotlin/com/tunjid/heron/timeline/state/Timeline.kt
Outdated
Show resolved
Hide resolved
data/core/src/commonMain/kotlin/com/tunjid/heron/data/repository/TimelineRepository.kt
Show resolved
Hide resolved
| ) = with(context) { | ||
| val lastItem = list.lastOrNull() | ||
| when { | ||
| // To start or for the OP, start a new thread |
There was a problem hiding this comment.
I think this method should be left alone, its trying to do two things. You should have a different method for reply building.
There was a problem hiding this comment.
After switching postThreadedItems to use ::spinReplyTree, spinThread is no longer called anywhere in the codebase. I want to make sure I understand the intent here, should spinThread be removed for now and reintroduced when there is an actual call site for it or is there a planned use case coming that I should be aware of so I can keep it in place?
2 participants
No description provided.