Move listMembers method to ListRepository

[tunjid]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring effort to improve the architectural organization of data repositories. The listMembers method, which handles retrieving members of a list, has been relocated from the ProfileRepository to the RecordRepository. This change enhances the separation of concerns by placing list-related data operations within a repository dedicated to records, leading to a more logical and maintainable codebase. The update also includes adjusting all affected view models to consume the functionality from its new location.

Highlights

• Refactoring of listMembers method: The listMembers method, including its interface definition and implementation, has been moved from ProfileRepository to RecordRepository to better align with its data domain.
• Dependency Updates: Consumers of the listMembers method, specifically ListViewModel and SearchViewModel, have been updated to now depend on and utilize the RecordRepository for this functionality, removing their previous dependency on ProfileRepository for list member operations.
• Import and Entity Adjustments: Necessary imports for GetListQueryParams, GetListResponse, ListMember, PopulatedListMemberEntity, and AtUri were added to RecordRepository to support the moved functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• data/core/src/commonMain/kotlin/com/tunjid/heron/data/repository/ProfileRepository.kt
  • Removed the listMembers method from the ProfileRepository interface and its OfflineProfileRepository implementation.
• data/core/src/commonMain/kotlin/com/tunjid/heron/data/repository/RecordRepository.kt
  • Added imports for GetListQueryParams, GetListResponse, ListMember, PopulatedListMemberEntity, and AtUri.
  • Introduced the listMembers method to the RecordRepository interface and its OfflineRecordRepository implementation, including the full logic for fetching list members.
• feature/list/src/commonMain/kotlin/com/tunjid/heron/list/ListViewModel.kt
  • Updated the ActualListViewModel constructor to inject recordRepository instead of profileRepository for list-related operations.
  • Modified the listMemberStateHolderMutations function to use recordRepository for loading list members.
• feature/search/src/commonMain/kotlin/com/tunjid/heron/search/SearchViewModel.kt
  • Removed the import and dependency injection of ProfileRepository.
  • Updated suggestedStarterPackMutations to utilize recordRepository for fetching list members associated with starter packs.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the codebase by moving the listMembers method from ProfileRepository to RecordRepository. This is a logical change that improves code organization and cohesion, as RecordRepository is a more suitable home for functionality related to generic list records. The call sites in ListViewModel and SearchViewModel have been correctly updated to reflect this change. The implementation is moved as-is, and the changes are consistent and well-executed across the affected files. I have no further comments on the implementation.