Skip to content

Set up notarization for Mac app#1148

Merged
tunjid merged 1 commit intomainfrom
tj/mac-github
Mar 26, 2026
Merged

Set up notarization for Mac app#1148
tunjid merged 1 commit intomainfrom
tj/mac-github

Conversation

@tunjid
Copy link
Copy Markdown
Owner

@tunjid tunjid commented Mar 26, 2026

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the necessary configurations and documentation to enable proper code signing and notarization for the macOS application. The changes facilitate a smoother distribution process by integrating Apple's security requirements into the build and publishing workflows, both locally and within continuous integration environments.

Highlights

  • macOS Code Signing Configuration: Configured the Gradle build script to conditionally sign macOS DMG files using a heron.macOS.signing.identity Gradle property, allowing contributors without an Apple Developer account to still build unsigned DMGs.
  • Notarization Process Documentation: Added comprehensive documentation to the README.md detailing the local notarization process using xcrun notarytool and explaining why it's handled externally to maintain Gradle configuration cache compatibility.
  • CI Publishing for macOS: Documented the Publish GitHub Actions workflow, specifically the publish-mac-app job, which now handles importing signing certificates, building signed DMGs, notarizing, stapling tickets, and attaching them to draft GitHub Releases.
  • Required CI Secrets: Listed all necessary repository secrets for CI publishing, including specific secrets for macOS signing and notarization such as MACOS_SIGNING_CERTIFICATE_P12_DATA, MACOS_NOTARIZATION_APPLE_ID, and MACOS_NOTARIZATION_TEAM_ID.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/publish.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive documentation for building and publishing the application, covering Gradle properties, macOS signing, notarization, and CI publishing secrets. The composeApp/build.gradle.kts file is updated to configure the macOS bundle ID and conditionally enable code signing based on the heron.macOS.signing.identity Gradle property. A review comment suggests an improvement to the macOS signing logic to explicitly check if the heron.macOS.signing.identity property's value is not blank, to prevent potential build failures if the property is present but empty.

@tunjid tunjid merged commit 463ee7c into main Mar 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant